Deny s3:ListBucket #203
Merged
Deny s3:ListBucket #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think it is reasonable to expand the comment to say that while ListBucket is denied it is still possible for someone to guess a valid URL and in that case this infrastructure would serve the file? |
ellismg
approved these changes
Jan 8, 2019
Merged
clstokes
added a commit
that referenced
this pull request
Jan 14, 2019
ramene
pushed a commit
to ramene/pulumi-kubeflow-ml
that referenced
this pull request
Sep 7, 2019
* Deny s3:ListBucket * Update comment
ramene
pushed a commit
to ramene/pulumi-kubeflow-ml
that referenced
this pull request
Sep 7, 2019
* Revert "Deny s3:ListBucket (pulumi#203)" This reverts commit 71225e5.
ramene
pushed a commit
to ramene/pulumi-kubeflow-ml
that referenced
this pull request
Sep 13, 2019
* Deny s3:ListBucket * Update comment
ramene
pushed a commit
to ramene/pulumi-kubeflow-ml
that referenced
this pull request
Sep 13, 2019
* Revert "Deny s3:ListBucket (pulumi#203)" This reverts commit 71225e5.
dixler
pushed a commit
that referenced
this pull request
Jan 21, 2022
* Deny s3:ListBucket * Update comment
dixler
pushed a commit
that referenced
this pull request
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the static website on AWS example to deny the
s3:ListBucketpermission. We set the "public-read" ACL on the bucket, so that CloudFront can read the bucket's contents. However, just following best practices with regard to content security, we deny thes3:ListBucketpermission to prevent unintentional disclosure of the website's contents.See pulumi/get.pulumi.com#33, pulumi/docs#734