Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcp(gke): wordsmithing & feedback parity from gke-hello-world tutorial #228

Merged
merged 1 commit into from
Feb 8, 2019
Merged

gcp(gke): wordsmithing & feedback parity from gke-hello-world tutorial #228

merged 1 commit into from
Feb 8, 2019

Conversation

metral
Copy link
Contributor

@metral metral commented Feb 8, 2019

No description provided.

@metral metral requested a review from lukehoban February 8, 2019 19:36
@metral metral force-pushed the metral/gke-feedback-parity branch 2 times, most recently from b313293 to 9849f46 Compare February 8, 2019 19:39
lukehoban
lukehoban approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukehoban lukehoban merged commit 43e60f2 into master Feb 8, 2019
@pulumi-bot pulumi-bot deleted the metral/gke-feedback-parity branch February 8, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehoban lukehoban lukehoban approved these changes

@lblackstone lblackstone lblackstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metral @lukehoban @lblackstone