Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindByUrn method for grpclog package #68

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Conversation

EronWright
Copy link
Contributor

Utility method to find a given resource by URN.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c45fd2) 33.45% compared to head (f97b518) 37.00%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   33.45%   37.00%   +3.55%     
==========================================
  Files          42       42              
  Lines        2571     2643      +72     
==========================================
+ Hits          860      978     +118     
+ Misses       1606     1561      -45     
+ Partials      105      104       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@blampe blampe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good but I want to understand what's going on with copylocks.

grpclog/grpclog.go Outdated Show resolved Hide resolved
grpclog/grpclog.go Show resolved Hide resolved
grpclog/grpclog.go Outdated Show resolved Hide resolved
grpclog/grpclog.go Outdated Show resolved Hide resolved
@EronWright EronWright merged commit 40a1856 into main Feb 21, 2024
4 checks passed
@EronWright EronWright deleted the eronwright/find-by-urn branch February 21, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants