Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compiling on Windows #72

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Enable compiling on Windows #72

merged 2 commits into from
Mar 5, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Mar 4, 2024

Fixes #71

This change enables compiling depending projects, such as Terraform Bridge tests, on Windows.

syscall.Stat_t is not defined on windows.

To reproduce, GOOS=windows go build ./....

@t0yv0 t0yv0 requested a review from a team March 4, 2024 23:09
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 37.38%. Comparing base (dd332f3) to head (47431d4).
Report is 11 commits behind head on main.

Files Patch % Lines
pulumitest/copy.go 28.57% 3 Missing and 2 partials ⚠️
pulumitest/fs_unix.go 60.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   37.27%   37.38%   +0.10%     
==========================================
  Files          42       43       +1     
  Lines        2664     2675      +11     
==========================================
+ Hits          993     1000       +7     
- Misses       1565     1568       +3     
- Partials      106      107       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pulumitest/fs_unix.go Outdated Show resolved Hide resolved
Co-authored-by: Ian Wahbe <ian@wahbe.com>
@t0yv0 t0yv0 merged commit 26697c7 into main Mar 5, 2024
2 checks passed
@t0yv0 t0yv0 deleted the t0yv0/win-compile branch March 5, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible to avoid syscall?
2 participants