Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go SDK does not compile #51

Closed
lukehoban opened this issue Jul 6, 2022 · 3 comments · Fixed by #52
Closed

Go SDK does not compile #51

lukehoban opened this issue Jul 6, 2022 · 3 comments · Fixed by #52
Assignees
@stack72
Labels
kind/bug Some behavior is incorrect or out of spec p1 Bugs severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Milestone
0.75

Comments

@lukehoban
Copy link
Member

lukehoban commented Jul 6, 2022 •
edited

What happened?

The Go SDK cannot be used - it fails to compile with:

# github.com/pulumi/pulumi-aws-apigateway/sdk/go/apigateway
../../../../go/pkg/mod/github.com/pulumi/pulumi-aws-apigateway/sdk@v0.0.7/go/apigateway/restAPI.go:92:11: undefined: RouteArgs

Steps to reproduce

Run any program which tries to reference v0.0.7 or later of this package in Go, such as the Go example in the examples folder.

Expected Behavior

It compiles.

Actual Behavior

It doesn't compile.

Versions used

No response

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@lukehoban lukehoban added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Jul 6, 2022
@lukehoban
Copy link
Member Author

This was broken by the changes in 0dad4f9#diff-2a40442b8af6a6d09227e933b4ef86132782123c989e0909c2223785c6c27619 as part of #20.

@stack72 stack72 self-assigned this Jul 8, 2022
@stack72 stack72 added p1 Bugs severe enough to be the next item assigned to an engineer and removed needs-triage Needs attention from the triage team labels Jul 8, 2022
@stack72 stack72 added this to the 0.75 milestone Jul 8, 2022
@stack72
Copy link
Contributor

stack72 commented Jul 8, 2022

@AaronFriel as discussed

@AaronFriel
Copy link
Member

I've bisected the change to a commit in this PR: pulumi/pulumi#7943

@AaronFriel AaronFriel mentioned this issue Jul 8, 2022
Open
3 tasks
stack72 added a commit that referenced this issue Jul 10, 2022
@stack72
[internal] Generate Input types for the Go SDK
5e07cde 
Fixes: #51
@stack72 stack72 mentioned this issue Jul 10, 2022
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stack72 stack72

Labels
kind/bug Some behavior is incorrect or out of spec p1 Bugs severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.75
Development

Successfully merging a pull request may close this issue.

[internal] Generate Input types for the Go SDK pulumi/pulumi-aws-apigateway
4 participants
@lukehoban @stack72 @AaronFriel @pulumi-bot