Rename to AWS native #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhailshilkov
force-pushed
the
mikhailshilkov/aws-native
branch
from
52eb49e
to
f55d134
Compare
lblackstone
approved these changes
Mar 4, 2021
| @@ -649,14 +654,14 @@ var updatePolicyTypes = map[string]pschema.ComplexTypeSpec{ | |||
| "MaxBatchSize": { | |||
| Description: "Specifies the maximum number of instances that AWS CloudFormation updates.", | |||
| TypeSpec: primitiveTypeSpec("Integer"), | |||
| Default: 1, | |||
| Default: 1.0, | |||
There was a problem hiding this comment.
Why are these specified as floats if the type is Integer?
There was a problem hiding this comment.
This is an odd one! Our schema codegen fails with a bizarre message that int can't be a default to integer. I'll open an issue!
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #3
Go generation is broken due to
aws-nativelurking into the code. I will open a separate issue.