Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gp3 storage in RDS #2223

Merged
merged 3 commits into from
Dec 7, 2022
Merged

Conversation

jamie1911
Copy link
Contributor

RDS supports gp3 storage types for multiple RDS configurations. Allow the selection of gp3 storage type.

https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/CHAP_Storage.html#Concepts.Storage.GeneralSSD

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@danielrbradley
Copy link
Member

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

Please view the PR build: https://github.com/pulumi/pulumi-aws/actions/runs/3516059129

@danielrbradley
Copy link
Member

@jamie1911 before we can merge this we also need to re-generate the SDKs so they reflect the updated schema. Running make build_sdks should do this for you

@thomas11
Copy link
Contributor

thomas11 commented Dec 2, 2022

@thomas11
Copy link
Contributor

thomas11 commented Dec 3, 2022

#2242 brings the upstream addition of gp3

@jamie1911
Copy link
Contributor Author

@jamie1911 before we can merge this we also need to re-generate the SDKs so they reflect the updated schema. Running make build_sdks should do this for you

I can't seem to get this to update correctly, it keeps trying to change all comments in the files from github.com/pulumi/pulumi-aws/sdk/v5/**/* to github.com/pulumi/pulumi-aws/sdk/**/*

@danielrbradley
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@pulumi-bot
Copy link
Contributor

Please view the PR build: https://github.com/pulumi/pulumi-aws/actions/runs/3631250213

@danielrbradley
Copy link
Member

Right, we're good to go 🚀

Thanks for your contribution and patience @jamie1911

@danielrbradley danielrbradley merged commit 1f2effd into pulumi:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants