WIP: expose PF-based resources #2464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
9 tasks
iwahbe
reviewed
Apr 14, 2023
Comment on lines
+18
to
+26
| primary, err := provider.New(ctx) | ||
| if err != nil { | ||
| panic(err) | ||
| return UpstreamProvider{}, err | ||
| } | ||
| return prov | ||
| pf := fwprovider.New(primary) | ||
| return UpstreamProvider{ | ||
| SDKV2Provider: primary, | ||
| PluginFrameworkProvider: pf, | ||
| }, nil |
There was a problem hiding this comment.
@t0yv0 I think the reason we are seeing behavior from the SDK side effect the PF side is because we are passing back the same provider (with its backing state).
There was a problem hiding this comment.
We have to do it. If we don't do it PF side is unable to deploy resources.
There was a problem hiding this comment.
Specifically it panics with malconfigured AWS client, which only gets configured in sdkv2-style callback. I can dig this up if it doesn't ring a bell.
|
Noticing weird SetAutoNaming interaction with @iwahbe - new resources based on PF do not yet support auto naming a runtime until pulumi/pulumi-terraform-bridge#917 is done but as written the schema-time SetAutonaming call works and makes their required "name" properties optional. The warning is elided due to incorrect check. Could move resource definitions around so that SetAutoNaming does not apply to them. Wondering if this is a blocker for releasing an update, can we release with a required "name" property and then relax to optional for the new resources? |
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
New functions:
|
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
New functions:
|
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
New functions:
|
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
New functions:
|
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
New functions:
|
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
New functions:
|
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
New functions:
|
|
Is this PR still relevant? |
I believe it was rendered unnecessary by #2557. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.