Use Plugin Framework bridge to bring in new resources #2557
Conversation
| @@ -5927,6 +5941,20 @@ func Provider() tfbridge.ProviderInfo { | |||
| }, | |||
| }, | |||
| DataSources: map[string]*tfbridge.DataSourceInfo{ | |||
|
|
|||
| "aws_auditmanager_control": { | |||
There was a problem hiding this comment.
These new functions come from PF:
auditmanager/getControl.getControl
auditmanager/getFramework.getFramework
vpc/getSecurityGroupRule.getSecurityGroupRule
vpc/getSecurityGroupRules.getSecurityGroupRules
| @@ -6100,7 +6128,6 @@ func Provider() tfbridge.ProviderInfo { | |||
| "aws_security_group": {Tok: awsDataSource(ec2Mod, "getSecurityGroup")}, | |||
| "aws_security_groups": {Tok: awsDataSource(ec2Mod, "getSecurityGroups")}, | |||
| "aws_subnet": {Tok: awsDataSource(ec2Mod, "getSubnet")}, | |||
| "aws_subnet_ids": {Tok: awsDataSource(ec2Mod, "getSubnetIds")}, | |||
There was a problem hiding this comment.
Probably orthogonal to this PR, it resolves a warning:
warning: Pulumi token "aws:ec2/getSubnetIds:getSubnetIds" is mapped to TF provider data source "aws_subnet_ids", but no such data source found. The mapping will be ignored in the generated provider
From ./upstream:
.changelog/22743.txt:data-source/aws_subnet_ids: The `aws_subnet_ids` data source has been deprecated and will be removed in a future version. Use the `aws_subnets` data source instead
| prov.Resources[k] = v | ||
| } | ||
|
|
||
| // TODO fix C# compilation error for QuickSight Namespace |
There was a problem hiding this comment.
This is copied from the former PR I had, I think we need to fix this better, so as to support aws_quicksight_namespace somehow.
| prov.SetAutonaming(255, "-") | ||
|
|
||
| // Add a CSharp-specific override for aws_s3_bucket.bucket. | ||
| prov.Resources["aws_s3_bucket_legacy"].Fields["bucket"].CSharpName = "BucketName" | ||
|
|
||
| return prov | ||
| pluginFrameworkResoures := map[string]*tfbridge.ResourceInfo{ | ||
| "aws_auditmanager_account_registration": { |
There was a problem hiding this comment.
These new resources come from PF.
|
This did not run tests. Changing base to master to try to make the tests run. |
|
I think prerequisites compilation should unblock once #2558 is in. |
|
Looks like there's still some |
Mapping for aws_directory_service_trust is removed to unblock C# sdk generation and compilation error
This change was lost while rebasing. Adding it back in so tests/resources work as expected.
Bring in newer pu/pu so the test harness framework support Pulumi yaml.
Does the PR have any schema changes?Found 139 breaking changes: New resources:
New functions:
|
| github.com/pulumi/pulumi/pkg/v3 v3.31.1 | ||
| github.com/stretchr/testify v1.7.1 | ||
| github.com/aws/aws-sdk-go v1.44.122 | ||
| github.com/pulumi/pulumi/pkg/v3 v3.71.0 |
There was a problem hiding this comment.
This implicitly upgrades ProgramTest framework hitting pulumi/pulumi#12859 ; I think this explains TestAccWebServer failure.
Does the PR have any schema changes?Found 139 breaking changes: New resources:
New functions:
|
Does the PR have any schema changes?Found 139 breaking changes: New resources:
New functions:
|
Start serving some resources off Plugin Framework Add acceptance test for PF based resources Use PlanState for diff strategy with provider Bring in newer pu/pu so the test harness framework support Pulumi yaml. Skip EditDirs in TestAccWebserver to workaround pulumi/pulumi#12859 --------- Co-authored-by: Ramon Quitales <ramon@pulumi.com>
Fixes #2548
This does a couple of things on top of rquitales/upgrade-v5-alpha.1: