[Draft/v6] Refactor WafV2 types to recursive #2588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update upstream to patched v5.1.0-alpha.1 and run patch * Run `make tfgen` * Update Go module package name to v6 suffix * Remove problematic quicksight dashboard and analytics definition property * Run `make tfgen build_sdks` * Use PlanState for diff strategy with provider * tests: Fix broken CodeBuild test by removing deprecated fields * Fix v6 import for Go examples Run `VERSION_PREFIX=6.0.0 make tfgen build_sdks` * Update examples and SDK to v6
Start serving some resources off Plugin Framework Add acceptance test for PF based resources Use PlanState for diff strategy with provider Bring in newer pu/pu so the test harness framework support Pulumi yaml. Skip EditDirs in TestAccWebserver to workaround pulumi/pulumi#12859 --------- Co-authored-by: Ramon Quitales <ramon@pulumi.com>
This reinstates 2 resources that were skipped to avoid C# SDK compilation issues, removing the TODOs.
Does the PR have any schema changes?Does the PR have any schema changes?Found 500 breaking changes: Resources
Functions
Types
New resources:
New functions:
Maintainer note: consult the runbook for dealing with any breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WafV2 module has two problematic resources with massive schemas. Because TF can't represent recursive schema types, they brute-force generated approximations of recursive types a few layers down. Example:
https://github.com/hashicorp/terraform-provider-aws/blob/5c5ab41aad82960be2dc8f0ed201098e260cd07a/internal/service/wafv2/schemas.go#L45
This leads to massive SDK sizes on Pulumi size. However, Pulumi does support recursive types. This PR uses a heuristic to find all references to all
Statementtypes and replace those references with a reference to the single top-levelStatementtypes. It then removes all unneeded types to gain a massive advantage in terms SDKs size.We still need to finalize how to ship this PR. I opened it against master for review, but I hope we can merge it into v6 instead before the GA is released.
Fix #2276
Fix #1117
Fix #2250
Fix pulumi/pulumi#8950