Fix aws.s3.Bucket tag drift detection

[t0yv0]

Make sure that pulumi refresh detects changes to bucket tagging.

The implementation restores aws_s3_legacy_bucket resource participation in the generic tags interceptor.

Fixes #3674

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

[github-actions]

Is README.md missing any configuration options?

assumeRoleWithWebIdentity not found in Configuration section
customCaBundle not found in Configuration section
defaultTags not found in Configuration section
ec2MetadataServiceEndpoint not found in Configuration section
ec2MetadataServiceEndpointMode not found in Configuration section
httpProxy not found in Configuration section
httpsProxy not found in Configuration section
ignoreTags not found in Configuration section
noProxy not found in Configuration section
retryMode not found in Configuration section
s3UsEast1RegionalEndpoint not found in Configuration section
sharedConfigFiles not found in Configuration section
skipRequestingAccountId not found in Configuration section
stsRegion not found in Configuration section
tokenBucketRateLimiterCapacity not found in Configuration section
useDualstackEndpoint not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

[t0yv0]

The randomized tagging tests flagged legacy-bucket not behaving correctly which is very relevant to this change. Specifically the randomized state transition defying the expectation is:

     {"defaultTags":{"x":"","y":"s"},"resourceTags":{"x":"s","y":"s"}}
 --> {"defaultTags":{},"resourceTags":{"x":"","y":"s"}

      expected: map[string]string{"x":"", "y":"s"}
      actual  : map[string]string{"x":"s", "y":"s"}

We have seen flakes here before due to tag retrieval eventual consistency but I'm going to double check since this very well may be an actual problem.

[t0yv0]

Doesn't reproduce locally, must have been a flake.

[corymhall]

@t0yv0 I'm assuming that adding the legacy bucket as a ServicePackage is what enrolls it into the generic tags? Is there any other implications of doing this, I'm not very familiar with what ServicePackage does.

[t0yv0]

I think yes that's it. https://github.com/hashicorp/terraform-provider-aws/blob/master/internal/provider/provider.go#L39 walks through all ServicePackage defined resources and https://github.com/hashicorp/terraform-provider-aws/blob/master/internal/provider/provider.go#L329 installs the interceptor. It looks like it does a few checks. I think it's reasonable for the legacy bucket to participate here.

[flostadler]

LGTM