Fix empty retry_strategy of Batch JobDefinition causing panics #3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
lumiere-bot bot
added a commit
to coolguy1771/home-ops
that referenced
this pull request
May 15, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.34.1` -> `6.35.0`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.34.1/6.35.0) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@​pulumi/aws)</summary> ### [`v6.35.0`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.35.0) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.34.1...v6.35.0) ##### Changelog - Fix aws.s3.Bucket tag drift detection by [@​t0yv0](https://togithub.com/t0yv0) in [pulumi/pulumi-aws#3910 - Fix empty retry_strategy of Batch JobDefinition causing panics by [@​flostadler](https://togithub.com/flostadler) in [pulumi/pulumi-aws#3921 - Combined dependencies PR by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [pulumi/pulumi-aws#3928 - Bump the go_modules group across 3 directories with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [pulumi/pulumi-aws#3894 **Full Changelog**: pulumi/pulumi-aws@v6.34.1...v6.35.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTYuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM1Ni4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL21pbm9yIl19--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lumiere-bot bot
added a commit
to coolguy1771/home-ops
that referenced
this pull request
May 15, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.34.1` -> `6.35.0`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.34.1/6.35.0) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@​pulumi/aws)</summary> ### [`v6.35.0`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.35.0) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.34.1...v6.35.0) ##### Changelog - Fix aws.s3.Bucket tag drift detection by [@​t0yv0](https://togithub.com/t0yv0) in [pulumi/pulumi-aws#3910 - Fix empty retry_strategy of Batch JobDefinition causing panics by [@​flostadler](https://togithub.com/flostadler) in [pulumi/pulumi-aws#3921 - Combined dependencies PR by [@​pulumi-bot](https://togithub.com/pulumi-bot) in [pulumi/pulumi-aws#3928 - Bump the go_modules group across 3 directories with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [pulumi/pulumi-aws#3894 **Full Changelog**: pulumi/pulumi-aws@v6.34.1...v6.35.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTYuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM1Ni4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL21pbm9yIl19--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computing whether a Batch JobDefinition has a diff panics if the
retry_strategyis empty. This is a valid configuration because all properties ofretry_strategyare optional.This patch fixes that by adding the missing nil checks for the retry strategy.
What's notable is that having an empty
retry_strategywill cause a perma diff.MaxItems=1blocks with all optional attributes lead to permanent diffs if the user provides an empty block.Fixes #3905