Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating vpc with ec2.Vpc is not properly tagging resources #161

Closed
Incisive opened this issue Feb 24, 2019 · 2 comments
Closed

Creating vpc with ec2.Vpc is not properly tagging resources #161

Incisive opened this issue Feb 24, 2019 · 2 comments
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@Incisive
Copy link

Incisive commented Feb 24, 2019

When creating a VPC with the awsx.ec2.Vpc class, the resulting resources are not receiving the Name tag. Previously the awsx.Network class was creating these tags, which is why I'm curious if this functionality was changed.

Below is the example statement I'm using when creating a VPC:

const vpc = new awsx.ec2.Vpc(
    `secrets-scanner-${env}`,
    {
        cidrBlock: '10.10.0.0/16',
        numberOfAvailabilityZones: 2,
    },
    { protect: true }
);

And here are the versions of the Pulumi libraries I'm using in my package.json:

"dependencies": {
    "@pulumi/aws": "latest",
    "@pulumi/awsx": "^0.16.4",
    "@pulumi/cloud": "^0.16.2",
    "@pulumi/cloud-aws": "^0.16.2",
    "@pulumi/pulumi": "latest"
  }
@stack72
Copy link
Contributor

stack72 commented May 12, 2022

@jkodroff i believe we now create the Name tag by default on the resources as part of our recent rewrite, correct?

@lukehoban lukehoban added kind/enhancement Improvements or new features resolution/fixed This issue was fixed labels Nov 19, 2022
@lukehoban
Copy link
Member

i believe we now create the Name tag by default on the resources as part of our recent rewrite, correct?

Confirmed that we do with the 1.0.0-beta releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

4 participants