Extract 'aws-infra' types into their own package independent of cloud-aws #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
changed the title
CyrusNajmabadi
commented
May 3, 2018
| // TODO[pulumi/pulumi#377] Workaround for issue with long names not generating per-deplioyment randomness, leading | ||
| // to collisions. For now, limit the size of hashes to ensure we generate shorter/ resource names. | ||
| return shasum.digest("hex").substring(0, 8); | ||
| } |
There was a problem hiding this comment.
this code was copied. but it's so simple i don't mind that.
CyrusNajmabadi
commented
May 3, 2018
| @@ -82,23 +81,23 @@ export function getComputeIAMRolePolicies(): aws.ARN[] { | |||
| return computePolicies; | |||
| } | |||
|
|
|||
| let network: Network; | |||
| let network: awsinfra.Network; | |||
There was a problem hiding this comment.
i preferred making it explicit tht these are from another module.
added 2 commits
May 3, 2018 14:51
lukehoban
approved these changes
May 4, 2018
aws/examples/cluster/package.json
Outdated
| @@ -13,6 +13,7 @@ | |||
| "peerDependencies": { | |||
| "@pulumi/pulumi": "^0.11.2", | |||
| "@pulumi/cloud": "latest", | |||
| "@pulumi/cloud-aws": "latest" | |||
| "@pulumi/cloud-aws": "latest", | |||
There was a problem hiding this comment.
I don't think we need cloud-aws here anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: further work will be done her.e For example, this change does not include changes to make cluster/network into components. I wanted to do the minimal amount to just the code into a separate package.