Set AWS EKS cluster name

[gregbacchus]

When creating the aws.eks.Cluster, it would be great if the name property that is provided would passed in would be passed in. This way the AWS resource created will have a sensible name and will then be easily identifiable.

All that is required is to pass the name to the aws.eks.Cluster opts argument

pulumi-eks/nodejs/eks/cluster.ts

Lines 332 to 334 in 79fb423

	const eksCluster = new aws.eks.Cluster(`${name}-eksCluster`, {
	roleArn: eksRole.apply(r => r.arn),
	vpcConfig: {

  const eksCluster = new aws.eks.Cluster(`${name}-eksCluster`, {
      name,
      roleArn: eksRole.apply(r => r.arn), 
      vpcConfig: { 
      ...

[pgavlin]

We generally leave autonaming on to lower the probability of the resources in two stacks ending up with conflicting names, but this does seem like a reasonable configuration point we could provide (i.e. we could optionally do what you're suggesting while still making autonaming the default behavior).

[gregbacchus]

Yes that would be ok. I just started using it with the auto name and it caused issues because in another script I needed to reference it, which I couldn't. So I had to take a copy of the while thing and add a one love change.. not ideal. The other option would be some other way to make it easier to override smaller bits of functionality

[gregbacchus]

One of the reasons that it is useful to have a known name for the EKS cluster, is that you need to add a tag to the subnets kubernetes.io/cluster/${eksClusterName}: 'shared', and you need to create the subnets before you create the EKS cluster.

Without that tag on the subnets, AWS has problems auto-creating the load balancers required by the k8s services.

See
https://docs.aws.amazon.com/eks/latest/userguide/network_reqs.html

[icereed]

Hey @gregbacchus, fighting the same issue. Did you find a solution?
Otherwise I would also like to have the feature so we can preset the name.

[gregbacchus]

The only solution that I have found is to copy the class into my project and make the required change (only a single line, if I remember correctly)

…

On Fri, 7 Feb 2020, 00:25 Icereed, ***@***.***> wrote: Hey @gregbacchus <https://github.com/gregbacchus>, fighting the same issue. Did you find a solution? Otherwise I would also like to have the feature so we can preset the name. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#277?email_source=notifications&email_token=AANOCSG6RY2A6UTMTZBWH7LRBPXSNA5CNFSM4JOL4F5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK6357Q#issuecomment-582860542>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANOCSDJERYQKPYSRRNBJLTRBPXSNANCNFSM4JOL4F5A> .

[advissor]

So, what is the solution for this ?
I've tried to create a cluster today and it misses the required tags on subnets
kubernetes.io/cluster/${eksClusterName}: 'shared'

So, the whole thing stalls until timeout for 30 mins.. And, there not gonna be any messages, until you fight for some hours deleting partially resources

[gregbacchus]

You can now specify the name in the options

const cluster = new Cluster(name, {
    name,
    // ...
  }, {...});