feat(cluster): allow optional configuration of cluster name #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metral
force-pushed
the
metral/static-name
branch
from
005b3c6
to
7f30a3d
Compare
lblackstone
approved these changes
Feb 7, 2020
lukehoban
reviewed
Feb 9, 2020
metral
force-pushed
the
metral/static-name
branch
from
7f30a3d
to
2f8d82e
Compare
|
Feedback has been addressed. PTAL @lukehoban |
metral
changed the title
metral
force-pushed
the
metral/static-name
branch
from
2f8d82e
to
2cbb8ba
Compare
lukehoban
requested changes
Feb 13, 2020
metral
force-pushed
the
metral/static-name
branch
2 times, most recently
from
52a324a
to
edb0865
Compare
|
Changes are g2g @lukehoban |
lukehoban
approved these changes
Feb 13, 2020
metral
force-pushed
the
metral/static-name
branch
from
edb0865
to
b082a4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
feat(cluster): allow optional configuration of cluster name
Related issues (optional)
Closes #277
Closes #240
Closes #118