Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tags): Set default tags & add opts: cluster tags, and other resource tags #122

Merged
merged 7 commits into from
May 3, 2019

Conversation

metral
Copy link
Contributor

@metral metral commented May 2, 2019

Fixes #74 - "Everything that can be tagged is now tagged."

This PR does the following:

  • Adds a couple of new options:
    • Cluster class:
      • .tags - A map of tags that is applied to all AWS resources under management by a pulumi/eks cluster. Currently applied to: eksClusterSecurityGroup, nodeSecurityGroup, the Worker AutoScalingGroup (ASG), and cloudFormation stack.
      • .clusterSecurityGroupTags - A map of tags applied to the EKS Cluster security group
    • NodeGroup class:
      • .nodeSecurityGroupTags - A map of tags applied to the Worker Nodes security group
      • .cloudFormationTags - A map of tags applied to the CloudFormation Stack of Worker Nodes
      • .autoScalingGroupTags - A map of tags applied to the Worker NodeGroup ASG & Instances
  • Also, set the default "Name" tag for each: eksClusterSecurityGroup, nodeSecurityGroup, and the Worker CloudFormation stack. The Worker ASG already had one set.

See the table for the:

  • AWS resources under management by the cluster
  • their new resource tag xTags name (if applicable)
  • whether it has the default "Name" tag, and
  • if it includes the .tags set for all resources under management by the cluster.
AWS Resource Can be tagged? Resource Tag Name Has default 'Name' Tag? Includes .tags
eksCluster No
eksClusterIngressRule No
eksClusterInternetEgressRule No
eksClusterSecurityGroup Yes clusterSecurityGroupTags Yes Yes
eksExtApiServerClusterIngressRule No
eksNodeClusterIngressRule No
eksNodeIngressRule No
eksNodeInternetEgressRule No
eksRole Yes see (#119) Not yet Not yet
2x eksRolePolicyAttachment No
instanceProfile No
instanceRole Yes see (#119) Not yet Not yet
3x instanceRolePolicyAttachment No
nodeLaunchConfiguration No
nodeSecurityGroup Yes nodeSecurityGroupTags Yes Yes
autoScalingGroup & Instances Yes autoScalingGroupTags Yes Yes
cloudFormation Stack Yes cloudFormationTags Yes Yes

metral added a commit that referenced this pull request May 2, 2019
metral added a commit that referenced this pull request May 2, 2019
metral added a commit that referenced this pull request May 2, 2019
Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one question around Name.

nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@metral
Copy link
Contributor Author

metral commented May 2, 2019

This PR was tested on an existing cluster using v0.18.3 and PASSED.

metral added a commit that referenced this pull request May 2, 2019
metral added a commit that referenced this pull request May 2, 2019
metral added a commit that referenced this pull request May 2, 2019
metral added a commit that referenced this pull request May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tagging of instances, ASGs, launch config, etc.
2 participants