fix(secgroups): do not null out ingress & egress #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just hit this myself |
- Note: This PR reverses the default null values used for the
ingress and egress in-line rules of the secgroups, introduced in `v0.18.3`.
The null default was required to move to standalone secgroup rules.
- Upgrade Path - This is a breaking change **unless** you do the
following steps:
- If using >= `v0.18.3`: update using the typical package update path.
- If using <= `v0.18.2`:
1. First, update your cluster from using your current version to `v0.18.4`.
1. Next, update your cluster from `v0.18.4` to `v0.18.5` (or higher) using the typical package update path.
metral
force-pushed
the
metral/fix-secgroup-rule-defaults
branch
from
bd17a63
to
8ccd4d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127
ingress and egress in-line rules of the secgroups, introduced in
v0.18.3.The null default was required to move to standalone secgroup rules.
v0.18.3: update using the typical package update path.v0.18.2:v0.18.4.v0.18.4tov0.18.5(or higher) using the typical package update path.