Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defaulting the secgroups in-line rules to null creates empty secgroups on a cluster replacement #127

Closed
metral opened this issue May 4, 2019 · 1 comment · Fixed by #128
Closed

Defaulting the secgroups in-line rules to null creates empty secgroups on a cluster replacement #127

metral opened this issue May 4, 2019 · 1 comment · Fixed by #128
Assignees
@metral
Milestone
0.23

Comments

@metral
Copy link
Contributor

metral commented May 4, 2019 •
edited
Loading

When repro'ing #69 (comment) and successfully completing cluster replacement after adding more subnets, destroying the cluster results in the same errors as #69 for all of the rules belonging to and including the nodeSecurityGroup.

The cause is tied to defaulting the ingress and egress rules to [] during the update that replaces the cluster, which never ends up recreating the secgroup rules. Then on the destroy, when the stand-alone secgroup rules resources are attempted to be deleted, because the rules were already removed / null'd out from the secgroup, we're returned the rule does not exist in the security group errors.

The null default for ingress & egress was intro'd in #109 as a requirement to be able to successfully update the cluster from using in-line secgroup rules to standalone rules.
@metral metral self-assigned this May 4, 2019
metral added a commit to metral/pulumi-eks that referenced this issue May 4, 2019
@metral
fix(secgroups): do not null out ingress & egress
2b8c602 
- Note: This PR reverses the default null values used for the
  ingress and egress in-line rules of the secgroups, introduced in `v0.18.3`.
  The null default was required to move to standalone secgroup rules, but it
  has introduced [issues](pulumi#127), and thus is being removed in this PR.
- Upgrade path:
  - If using >= `v0.18.3`: update using the typical package update path.
  - If using <= `v0.18.2`:
    1. First, update your cluster from using your current version to `v0.18.4`.
    1. Next, update your cluster from `v0.18.4` to `v0.18.5` (or higher) using the typical package update path.
@metral metral mentioned this issue May 4, 2019
Merged
@naineel
Copy link
Contributor

naineel commented May 7, 2019

Just hit this myself..The security groups are left empty with ingress and egress rules removed

@lukehoban lukehoban added this to the 0.23 milestone May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metral metral

Labels
None yet
Projects
None yet
Milestone
0.23
Development

Successfully merging a pull request may close this issue.

fix(secgroups): do not null out ingress & egress pulumi/pulumi-eks
3 participants
@lukehoban @metral @naineel