Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cluster): allow ClusterOptions to accept NodeGroupOptions #259

Merged
merged 2 commits into from
Oct 1, 2019
Merged

refactor(cluster): allow ClusterOptions to accept NodeGroupOptions #259

merged 2 commits into from
Oct 1, 2019

Conversation

metral
Copy link
Contributor

@metral metral commented Sep 25, 2019

Proposed changes

  • fix(Makefile): move clean from project Makefile to nodejs/eks Makefile
  • refactor(cluster): allow ClusterOptions to accept NodeGroupOptions

Related issues (optional)

#96

@metral metral changed the title Allow ClusterOptions to accept NodeGroupOptions refactor(cluster): allow ClusterOptions to accept NodeGroupOptions Sep 25, 2019
@metral metral force-pushed the metral/refactor-cluster-options-api branch from 22da38e to 2243c34 Compare September 25, 2019 01:59
@metral metral force-pushed the metral/refactor-cluster-options-api branch from 2243c34 to 2643dfb Compare September 25, 2019 18:34
lukehoban
lukehoban approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

build/common.mk Outdated Show resolved Hide resolved
nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
nodejs/eks/cluster.ts Show resolved Hide resolved
@metral metral force-pushed the metral/refactor-cluster-options-api branch 2 times, most recently from 530542e to 0574827 Compare September 30, 2019 21:22
@metral
Copy link
Contributor Author

metral commented Sep 30, 2019

Feedback has been addressed. PTAL @lukehoban

@metral metral force-pushed the metral/refactor-cluster-options-api branch 4 times, most recently from 9ba5f7b to 27712fe Compare September 30, 2019 23:57
lukehoban
lukehoban reviewed Oct 1, 2019
View reviewed changes
nodejs/eks/cluster.ts Show resolved Hide resolved
nodejs/eks/cluster.ts Show resolved Hide resolved
@metral
Copy link
Contributor Author

metral commented Oct 1, 2019

Feedback has been addressed. PTAL @lukehoban

@metral metral force-pushed the metral/refactor-cluster-options-api branch from b58be56 to d2624e6 Compare October 1, 2019 00:44
lukehoban
lukehoban approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metral metral merged commit aab0ed9 into master Oct 1, 2019
@pulumi-bot pulumi-bot deleted the metral/refactor-cluster-options-api branch October 1, 2019 01:49
@metral metral mentioned this pull request Oct 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehoban lukehoban lukehoban approved these changes

@pgavlin pgavlin Awaiting requested review from pgavlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@metral @lukehoban