-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClusterOptions and ClusterNodeGroupOptions inconsistency #96
Comments
Yes - I see no reason we can't add I would love to share the interfaces here as well, so that we don't have to duplicate things in both places. This may be slightly challenging because a few properties ended up with slightly different names in the two - but I think there are only one or two cases of that - and those could be special-cased while still sharing everything else. |
Btw, I would be interested in working on this (and the other two feature requests I opened today), if I could get a bit of mentoring. |
That would be great! If you DM @metral and I on the Pulumi Community Slack we can set up some time to chat about this (and other areas you raised issues on). |
I would also like to see some consistency here. I initially need |
Agreed! cc also @CyrusNajmabadi for thoughts on API design here. |
Closed with #259 |
I've noticed an inconsistency between
ClusterOptions
andCluserNodeGroupOptions
regardingkeyName
- that only exists in the latter.As you should be able to specify any
ClusterNodeGroupOptions
as part ofClusterOptions
, doesn't it make sense forClusterOptions
to have anodeGroupOptions
propery, instead of copying allClusterNodeGroupOptions
properties to it?The text was updated successfully, but these errors were encountered: