fix(vpc-cni): allow logLevel & logFile to be set, or defaulted if not #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metral
force-pushed
the
metral/fix-vpc-options
branch
from
049ffab
to
532be3b
Compare
Removing both settings from the raw YAML manifest, and defaulting its values to what upstream uses allows for proper configuration of the settings, rather than trying to retroactively patch the YAML.
metral
force-pushed
the
metral/fix-vpc-options
branch
from
532be3b
to
3be8715
Compare
lblackstone
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removing both settings from the raw YAML manifest, and defaulting its
values to what upstream uses allows for proper configuration
of the settings, rather than trying to retroactively patch the YAML.
Note, the YAML file is intact with upstream with the exception of the changes in this PR. Other than this change, we should not drift from upstream to maintain parity.
Related issues (optional)
Fixes #273