Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor managed nodegroup API and require its role be provided to the cluster #302

Merged
merged 7 commits into from
Feb 12, 2020
Merged

Refactor managed nodegroup API and require its role be provided to the cluster #302

merged 7 commits into from
Feb 12, 2020

Conversation

metral
Copy link
Contributor

@metral metral commented Jan 9, 2020 •
edited

Proposed changes

  • Refactoring the managed node group API to simplify its use (options in role vs role.ARN, make parent arg optional, and default node group name).
  • Ensuring a managed nodegroup's cluster has the respective role specified in its instanceRoles that the managed nodegroup role uses, and that will get set in aws-auth.
  • Ensuring managed node groups do not get removed from aws-auth when role or user mappings are provided after initial update

Related issues

Closes #285
Fixes #293

@metral metral added this to the 0.31 milestone Jan 9, 2020
@metral metral requested a review from pgavlin January 9, 2020 15:41
@metral metral force-pushed the metral/refactor-and-fix-managed-ng-access branch from 69b0ee3 to fa24f28 Compare January 9, 2020 15:44
@metral metral mentioned this pull request Jan 14, 2020
Closed
@metral metral requested review from lukehoban, lblackstone and pgavlin and removed request for lukehoban, lblackstone and pgavlin January 14, 2020 17:02
lblackstone
lblackstone requested changes Jan 14, 2020
View reviewed changes
nodejs/eks/nodegroup.ts Outdated Show resolved Hide resolved
nodejs/eks/nodegroup.ts Outdated Show resolved Hide resolved
nodejs/eks/nodegroup.ts Show resolved Hide resolved
nodejs/eks/nodegroup.ts Outdated Show resolved Hide resolved
nodejs/eks/nodegroup.ts Show resolved Hide resolved
nodejs/eks/nodegroup.ts Outdated Show resolved Hide resolved
nodejs/eks/examples/tests/managed-ng-aws-auth/step1/index.ts Outdated Show resolved Hide resolved
@metral metral requested review from lukehoban and removed request for lukehoban and pgavlin January 27, 2020 22:14
@metral metral force-pushed the metral/refactor-and-fix-managed-ng-access branch 11 times, most recently from 7caf624 to 2fa9c4c Compare January 30, 2020 18:00
@metral
Copy link
Contributor Author

metral commented Jan 30, 2020

@lukehoban any thoughts or comments before merging?

lblackstone
lblackstone requested changes Feb 4, 2020
View reviewed changes
nodejs/eks/nodegroup.ts Outdated Show resolved Hide resolved
nodejs/eks/nodegroup.ts Outdated Show resolved Hide resolved
nodejs/eks/nodegroup.ts Outdated Show resolved Hide resolved
nodejs/eks/nodegroup.ts Outdated Show resolved Hide resolved
@metral metral force-pushed the metral/refactor-and-fix-managed-ng-access branch from 2fa9c4c to 6acf763 Compare February 5, 2020 21:27
@metral
Copy link
Contributor Author

metral commented Feb 5, 2020

Feedback has been addressed. PTAL @lblackstone @lukehoban

lblackstone
lblackstone reviewed Feb 6, 2020
View reviewed changes
nodejs/eks/nodegroup.ts Outdated Show resolved Hide resolved
nodejs/eks/nodegroup.ts Outdated Show resolved Hide resolved
@metral metral force-pushed the metral/refactor-and-fix-managed-ng-access branch 4 times, most recently from ae91383 to 9f93ae1 Compare February 7, 2020 01:13
@metral
Copy link
Contributor Author

metral commented Feb 7, 2020

Feedback has been addressed. PTAL @lblackstone @lukehoban

@metral metral force-pushed the metral/refactor-and-fix-managed-ng-access branch from 79fce31 to 15c961b Compare February 7, 2020 21:21
@lukehoban lukehoban modified the milestones: 0.31, 0.32 Feb 10, 2020
@metral metral force-pushed the metral/refactor-and-fix-managed-ng-access branch from 15c961b to 7c4ec97 Compare February 12, 2020 00:05
@metral metral force-pushed the metral/refactor-and-fix-managed-ng-access branch 3 times, most recently from ab28802 to c9febf3 Compare February 12, 2020 17:40
@metral metral force-pushed the metral/refactor-and-fix-managed-ng-access branch 2 times, most recently from ff12982 to f7de4fc Compare February 12, 2020 17:52
@metral metral merged commit c165e0d into master Feb 12, 2020
@pulumi-bot pulumi-bot deleted the metral/refactor-and-fix-managed-ng-access branch February 12, 2020 19:30
@metral metral mentioned this pull request Feb 14, 2020
Merged
@Embraser01 Embraser01 mentioned this pull request Dec 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehoban lukehoban lukehoban left review comments

@lblackstone lblackstone lblackstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.32
3 participants
@metral @lukehoban @lblackstone