Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createManagedNodeGroup disable node group auto naming #491

Closed
Embraser01 opened this issue Dec 16, 2020 · 1 comment · Fixed by #492
Closed

createManagedNodeGroup disable node group auto naming #491

Embraser01 opened this issue Dec 16, 2020 · 1 comment · Fixed by #492
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@Embraser01
Copy link
Contributor

Problem description

A managed node group created throuh createManagedNodeGroup will not have an auto generated name on AWS.

The issue is the same as #294 but is caused by

nodeGroupName: args.nodeGroupName || name,

introduced in #302:

Refactoring the managed node group API to simplify its use (options in role vs role.ARN, make parent arg optional, and default node group name).

It causes the node group to be deleted before being replaced in case the config change (e.g. isntanceType). Is there a reason to not auto name it?

Errors & Logs

Reproducing the issue

Creating a node group and changing it's instanceType should reproduce the issue.

Suggestions for a fix

Removing the fallback to name should work.

@leezen leezen added the bug label Dec 18, 2020
@leezen
Copy link
Contributor

leezen commented Dec 18, 2020

The fix you suggest makes sense and autonaming it here would help with what you're describing. Happy to take a PR here if you'd like to submit one?

@infin8x infin8x added the kind/bug Some behavior is incorrect or out of spec label Jul 10, 2021
flostadler pushed a commit that referenced this issue Sep 4, 2024
`createManagedNodeGroup` had a fallback on the cluster name for `nodeGroupName` which disabled the auto naming feature which led `deleteBeforeReplace` to be true.

Fixes #491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants