Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unblock CI by disabling debug logging, rm unnecessary tests, and fixing broken tests #309

Merged
merged 8 commits into from
Jan 27, 2020
Merged

Unblock CI by disabling debug logging, rm unnecessary tests, and fixing broken tests #309

merged 8 commits into from
Jan 27, 2020

Conversation

metral
Copy link
Contributor

@metral metral commented Jan 21, 2020 •
edited

Proposed changes

  • Disable debug logging in pulumi tests
  • Disable withUpdate tests in hopes to unblock CI, possibly due to network saturation and/or resource starvation in Travis.
  • Remove unnecessary tests that are not strictly required (nodegroup-options) or outdated per API updates (awsx-network)
  • Fix compile errors in tests due to recent Pulumi API changes and use of TS v3.7

The examples/tests that are enabled with this PR are:

  1. examples/cluster
  2. examples/fargate
  3. examples/nodegroup
  4. examples/managed-nodegroups
  5. examples/storage-classes
  6. examples/tags
  7. examples/tests/migrate-nodegroups
  8. examples/tests/replace-cluster-add-subnets
  9. examples/tests/replace-secgroup
  10. examples/tests/tag-input-types

The examples/tests that are disabled with this PR are:

  1. examples/storage-classes withUpdate
  2. examples/tags withUpdate
  3. examples/cluster withUpdate
  4. examples/nodegroup withUpdate

The tests that have been removed with this PR are:

  1. examples/tests/awsx-network-and-subnetIds
  2. examples/tests/nodegroup-options

Related issues (optional)

@metral metral changed the title Unblock CI by disabling debug logging and tests Unblock CI by disabling debug logging, rm unnecessary tests, and fixing broken tests Jan 23, 2020
@metral metral merged commit 443724d into master Jan 27, 2020
@pulumi-bot pulumi-bot deleted the metral/unblock-ci branch January 27, 2020 22:11
@metral metral mentioned this pull request Jan 27, 2020
Closed
@metral metral added this to the 0.31 milestone Jan 27, 2020
@metral metral self-assigned this Jan 27, 2020
@metral metral mentioned this pull request Jan 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgavlin pgavlin pgavlin approved these changes

@lukehoban lukehoban Awaiting requested review from lukehoban

Assignees

@metral metral

Labels
area/testing
Projects
None yet
Milestone
0.31
Development

Successfully merging this pull request may close these issues.

Travis tests failing
2 participants
@metral @pgavlin