Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(travis): rm unused aws-iam-authenticator setup #380

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

metral
Copy link
Contributor

@metral metral commented Apr 17, 2020

Proposed changes

cleanup(travis): rm unused aws-iam-authenticator setup

Related issues (optional)

Closes #379

@metral
Copy link
Contributor Author

metral commented Apr 17, 2020

Note: (In Travis Only): this PR will fail all of the _withUpdate examples and tests that depend on Travis having the aws-iam-authenticator binary, as this is expected in the latest upstream pkg we're testing: v0.18.24

As #362 (comment) points out, we can successfully upgrade from clusters using the aws-iam-authenticator to aws get token - the kubeconfig for existing clusters will be recomputed, but cluster access and k8s resources are not impacted.

However, going to hold this one off until a new release is cut to ensure a green build

@metral metral added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Apr 21, 2020
@metral metral merged commit 98f4a7b into master Apr 21, 2020
@pulumi-bot pulumi-bot deleted the metral/cleanup-travis branch April 21, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup Travis config of the unused aws-iam-authenticator binary
3 participants