-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct spelling for encryptRootBlockDevice #450
Conversation
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
86783d2
to
360dbf6
Compare
/run-acceptance-tests |
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/342330188 |
this is a breaking change right? Can we do it in a way where we deprecate the old and point to the new and then be able to take them into account? |
360dbf6
to
70748b5
Compare
@stack72 Thanks for input. PTAL |
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
/run-acceptance-tests |
Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/342413995 |
70748b5
to
10d5e70
Compare
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
/run-acceptance-tests |
Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/342417794 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome! thanks
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
/run-acceptance-tests |
Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/342480143 |
1 similar comment
Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/342480143 |
/run-acceptance-tests |
Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/342777321 |
Proposed changes
fix: correct spelling for encryptRootBlockDevice
Related issues (optional)
Fixes #446