Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct spelling for encryptRootBlockDevice #450

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Conversation

metral
Copy link
Contributor

@metral metral commented Nov 2, 2020

Proposed changes

fix: correct spelling for encryptRootBlockDevice

Related issues (optional)

Fixes #446

@metral metral requested a review from stack72 November 2, 2020 19:37
@github-actions
Copy link

github-actions bot commented Nov 2, 2020

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@metral
Copy link
Contributor Author

metral commented Nov 2, 2020

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Nov 2, 2020

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

github-actions bot commented Nov 2, 2020

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/342330188

@stack72
Copy link
Contributor

stack72 commented Nov 2, 2020

this is a breaking change right? Can we do it in a way where we deprecate the old and point to the new and then be able to take them into account?

@metral
Copy link
Contributor Author

metral commented Nov 2, 2020

@stack72 Thanks for input. PTAL

@github-actions
Copy link

github-actions bot commented Nov 2, 2020

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@metral
Copy link
Contributor Author

metral commented Nov 2, 2020

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Nov 2, 2020

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/342413995

@github-actions
Copy link

github-actions bot commented Nov 2, 2020

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@metral
Copy link
Contributor Author

metral commented Nov 2, 2020

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Nov 2, 2020

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/342417794

Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome! thanks

@github-actions
Copy link

github-actions bot commented Nov 2, 2020

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@metral
Copy link
Contributor Author

metral commented Nov 2, 2020

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Nov 2, 2020

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/342480143

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 2, 2020

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/342480143

@metral
Copy link
Contributor Author

metral commented Nov 3, 2020

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/342777321

@metral metral merged commit c97e251 into master Nov 4, 2020
@pulumi-bot pulumi-bot deleted the metral/fix-field branch November 4, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

encryptRootBockDevice should be Block instead of Bock
2 participants