Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct spelling for encryptRootBlockDevice #450

Merged
merged 1 commit into from
Nov 4, 2020
+21 −2
Merged

fix: correct spelling for encryptRootBlockDevice #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

### Improvements

- fix: correct spelling for encryptRootBlockDevice
[#450](https://github.com/pulumi/pulumi-eks/pull/450)

## 0.20.0 (Released September 3, 2020)

### Improvements
Expand Down
10 changes: 9 additions & 1 deletion nodejs/eks/cluster.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ export function createCore(name: string, args: ClusterOptions, parent: pulumi.Co
nodeAssociatePublicIpAddress: args.nodeAssociatePublicIpAddress,
instanceType: args.instanceType,
nodePublicKey: args.nodePublicKey,
encryptRootBockDevice: args.encryptRootBockDevice,
encryptRootBlockDevice: args.encryptRootBlockDevice || args.encryptRootBockDevice,
nodeRootVolumeSize: args.nodeRootVolumeSize,
nodeUserData: args.nodeUserData,
minSize: args.minSize,
Expand Down Expand Up @@ -1003,9 +1003,17 @@ export interface ClusterOptions {

/**
* Encrypt the root block device of the nodes in the node group.
*
* @deprecated This option has been deprecated due to a misspelling.
* Use the correct encryptRootBlockDevice option instead.
*/
encryptRootBockDevice?: pulumi.Input<boolean>;

/**
* Encrypt the root block device of the nodes in the node group.
*/
encryptRootBlockDevice?: pulumi.Input<boolean>;

/**
* The tags to apply to the default `nodeSecurityGroup` created by the cluster.
*
Expand Down
10 changes: 9 additions & 1 deletion nodejs/eks/nodegroup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,17 @@ export interface NodeGroupBaseOptions {

/**
* Encrypt the root block device of the nodes in the node group.
*
* @deprecated This option has been deprecated due to a misspelling.
* Use the correct encryptRootBlockDevice option instead.
*/
encryptRootBockDevice?: pulumi.Input<boolean>;

/**
* Encrypt the root block device of the nodes in the node group.
*/
encryptRootBlockDevice?: pulumi.Input<boolean>;

/**
* Public key material for SSH access to worker nodes. See allowed formats at:
* https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-key-pairs.html
Expand Down Expand Up @@ -486,7 +494,7 @@ ${customUserData}
securityGroups: [nodeSecurityGroupId, ...extraNodeSecurityGroupIds],
spotPrice: args.spotPrice,
rootBlockDevice: {
encrypted: args.encryptRootBockDevice,
encrypted: args.encryptRootBlockDevice || args.encryptRootBockDevice,
volumeSize: args.nodeRootVolumeSize || 20, // GiB
volumeType: "gp2", // default is "standard"
deleteOnTermination: true,
Expand Down