Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port dynamic provider resources to custom resources #458

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

justinvp
Copy link
Member

@justinvp justinvp commented Nov 6, 2020

Dynamic providers don't currently work well with multi-language components. To workaround in the short term, the dynamic provider resources in this library have been ported to regular custom resources implemented in the new provider plugin. Aliases are used and care has been taken in the implementations inside the provider to avoid any diffs for any existing stacks that were created using the old dynamic provider -based resources.

This does mean that the @pulumi/eks node package will require the new eks plugin to be installed.

Fixes #451

@github-actions
Copy link

github-actions bot commented Nov 6, 2020

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@justinvp justinvp marked this pull request as ready for review November 20, 2020 17:44
@justinvp
Copy link
Member Author

@lblackstone, @pgavlin this is ready for review

nodejs/eks/cmd/provider/index.ts Outdated Show resolved Hide resolved
nodejs/eks/cmd/provider/index.ts Outdated Show resolved Hide resolved
nodejs/eks/cni.ts Outdated Show resolved Hide resolved
nodejs/eks/randomSuffix.ts Outdated Show resolved Hide resolved
nodejs/eks/transform.ts Show resolved Hide resolved
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@justinvp
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/376651632

@justinvp
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/376656359

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@justinvp
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/376726375

@justinvp
Copy link
Member Author

Need to wait until the acceptance tests have been hooked up in GHA to use the built provider. #456

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@justinvp justinvp added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 24, 2020
@justinvp
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/381989053

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@justinvp
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/382134709

@justinvp
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/382391214

Dynamic providers don't currently work well with multi-language
components. To workaround in the short term, the dynamic provider
resources in this library have been ported to regular custom resources
implemented in the new provider plugin. Aliases are used and care has
been taken in the implementations inside the provider to avoid any diffs
for any existing stacks that were created using the old dynamic provider
-based resources.
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@justinvp
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/382854405

1 similar comment
@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/382854405

@justinvp justinvp merged commit 77addf2 into master Nov 25, 2020
@pulumi-bot pulumi-bot deleted the justin/multilang_dynamic branch November 25, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port dynamic provider resources to be implemented as custom resources of the new provider plugin
2 participants