-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port dynamic provider resources to custom resources #458
Conversation
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
d8b8955
to
d3b275e
Compare
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
@lblackstone, @pgavlin this is ready for review |
d3b275e
to
7870a62
Compare
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
/run-acceptance-tests |
Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/376651632 |
/run-acceptance-tests |
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/376656359 |
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
/run-acceptance-tests |
Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/376726375 |
Need to wait until the acceptance tests have been hooked up in GHA to use the built provider. #456 |
213f4dd
to
eef78ae
Compare
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
/run-acceptance-tests |
Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/381989053 |
eef78ae
to
b4165ff
Compare
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
/run-acceptance-tests |
Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/382134709 |
/run-acceptance-tests |
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/382391214 |
Dynamic providers don't currently work well with multi-language components. To workaround in the short term, the dynamic provider resources in this library have been ported to regular custom resources implemented in the new provider plugin. Aliases are used and care has been taken in the implementations inside the provider to avoid any diffs for any existing stacks that were created using the old dynamic provider -based resources.
1064842
to
0118cbe
Compare
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
/run-acceptance-tests |
Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/382854405 |
1 similar comment
Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/382854405 |
Dynamic providers don't currently work well with multi-language components. To workaround in the short term, the dynamic provider resources in this library have been ported to regular custom resources implemented in the new provider plugin. Aliases are used and care has been taken in the implementations inside the provider to avoid any diffs for any existing stacks that were created using the old dynamic provider -based resources.
This does mean that the
@pulumi/eks
node package will require the neweks
plugin to be installed.Fixes #451