Skip to content

Commit

Permalink
Correctly compute plugin version for PEP440 style prereleases
Browse files Browse the repository at this point in the history
Fixes #732
  • Loading branch information
ellismg committed Aug 22, 2019
1 parent b45c311 commit 0417105
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## 1.0.0-beta.2 (Unreleased)

- Correctly compute version number for plugin to send with registration requests (fixes https://github.com/pulumi/pulumi-kubernetes/issues/732).

### Supported Kubernetes versions

- v1.15.x
Expand Down
8 changes: 7 additions & 1 deletion sdk/python/pulumi_kubernetes/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,13 @@ def get_version():
pep440_version = PEP440Version.parse(pep440_version_string)
(major, minor, patch) = pep440_version.release
prerelease = None
if pep440_version.dev is not None:
if pep440_version.pre_tag == 'a':
prerelease = f"alpha.{pep440_version.pre}"
elif pep440_version.pre_tag == 'b':
prerelease = f"beta.{pep440_version.pre}"
elif pep440_version.pre_tag == 'rc':
prerelease = f"rc.{pep440_version.pre}"
elif pep440_version.dev is not None:
prerelease = f"dev.{pep440_version.dev}"
# The only significant difference between PEP440 and semver as it pertains to us is that PEP440 has explicit support
# for dev builds, while semver encodes them as "prerelease" versions. In order to bridge between the two, we convert
Expand Down

0 comments on commit 0417105

Please sign in to comment.