Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_version() does not handle PEP440 style pre-releases #732

Closed
ellismg opened this issue Aug 22, 2019 · 0 comments · Fixed by #733
Closed

get_version() does not handle PEP440 style pre-releases #732

ellismg opened this issue Aug 22, 2019 · 0 comments · Fixed by #733
Assignees
@ellismg

Comments

@ellismg
Copy link
Contributor

ellismg commented Aug 22, 2019

Our recent switch to start using -beta and -alpha as pre-release versions (which are translated to PEP440 style a and b pre-release specificers) broke get_version()'s logic for converting the python version back to a semver to pass along to the engine.

We need to apply the same change we did pulumi/pulumi-terraform#461 for out terraform providers to our kubernetes provider.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellismg ellismg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly compute plugin version for PEP440 style prereleases pulumi/pulumi-kubernetes
1 participant
@ellismg