Skip to content

Commit

Permalink
Increase default readiness timeouts to 10 mins
Browse files Browse the repository at this point in the history
Deployment, Pod and StatefulSet resources previously
had default timeouts set to 5 minutes. Increase the
timeout to 10 minutes for consistency with other
resources.
  • Loading branch information
lblackstone committed Sep 17, 2019
1 parent f051f60 commit 3e68249
Show file tree
Hide file tree
Showing 20 changed files with 20 additions and 21 deletions.
3 changes: 1 addition & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
### Improvements

- Implement customTimeout for resource deletion. (https://github.com/pulumi/pulumi-kubernetes/pull/802).
- Increase default readiness timeouts to 10 mins. (https://github.com/pulumi/pulumi-kubernetes/pull/721).
- Warn for invalid usage of Helm repo parameter. (https://github.com/pulumi/pulumi-kubernetes/pull/805).

## 1.0.1 (September 11, 2019)
Expand Down Expand Up @@ -39,8 +40,6 @@
- v1.14.x
- v1.13.x

### Improvements

### Bug fixes

- Fix name collisions in the Charts/YAML Python packages
Expand Down
2 changes: 1 addition & 1 deletion pkg/await/apps_deployment.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ import (

const (
revision = "deployment.kubernetes.io/revision"
DefaultDeploymentTimeoutMins = 5
DefaultDeploymentTimeoutMins = 10
)

type deploymentInitAwaiter struct {
Expand Down
2 changes: 1 addition & 1 deletion pkg/await/apps_statefulset.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ import (
// ------------------------------------------------------------------------------------------------

const (
DefaultStatefulSetTimeoutMins = 5
DefaultStatefulSetTimeoutMins = 10
)

type statefulsetInitAwaiter struct {
Expand Down
2 changes: 1 addition & 1 deletion pkg/await/core_pod.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ import (
// --------------------------------------------------------------------------

const (
DefaultPodTimeoutMins = 5
DefaultPodTimeoutMins = 10
)

type podInitAwaiter struct {
Expand Down
2 changes: 1 addition & 1 deletion sdk/nodejs/apps/v1/Deployment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import { getVersion } from "../../version";
* because it doesn't do a rollout (i.e., it simply creates the Deployment and
* corresponding ReplicaSet), and therefore there is no rollout to mark as 'Progressing'.
*
* If the Deployment has not reached a Ready state after 5 minutes, it will
* If the Deployment has not reached a Ready state after 10 minutes, it will
* time out and mark the resource update as Failed. You can override the default timeout value
* by setting the 'customTimeouts' option on the resource.
*/
Expand Down
2 changes: 1 addition & 1 deletion sdk/nodejs/apps/v1/StatefulSet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { getVersion } from "../../version";
* and '.status.readyReplicas'.
* 2. The value of '.status.updateRevision' matches '.status.currentRevision'.
*
* If the StatefulSet has not reached a Ready state after 5 minutes, it will
* If the StatefulSet has not reached a Ready state after 10 minutes, it will
* time out and mark the resource update as Failed. You can override the default timeout value
* by setting the 'customTimeouts' option on the resource.
*/
Expand Down
2 changes: 1 addition & 1 deletion sdk/nodejs/apps/v1beta1/Deployment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import { getVersion } from "../../version";
* because it doesn't do a rollout (i.e., it simply creates the Deployment and
* corresponding ReplicaSet), and therefore there is no rollout to mark as 'Progressing'.
*
* If the Deployment has not reached a Ready state after 5 minutes, it will
* If the Deployment has not reached a Ready state after 10 minutes, it will
* time out and mark the resource update as Failed. You can override the default timeout value
* by setting the 'customTimeouts' option on the resource.
*/
Expand Down
2 changes: 1 addition & 1 deletion sdk/nodejs/apps/v1beta1/StatefulSet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import { getVersion } from "../../version";
* and '.status.readyReplicas'.
* 2. The value of '.status.updateRevision' matches '.status.currentRevision'.
*
* If the StatefulSet has not reached a Ready state after 5 minutes, it will
* If the StatefulSet has not reached a Ready state after 10 minutes, it will
* time out and mark the resource update as Failed. You can override the default timeout value
* by setting the 'customTimeouts' option on the resource.
*/
Expand Down
2 changes: 1 addition & 1 deletion sdk/nodejs/apps/v1beta2/Deployment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import { getVersion } from "../../version";
* because it doesn't do a rollout (i.e., it simply creates the Deployment and
* corresponding ReplicaSet), and therefore there is no rollout to mark as 'Progressing'.
*
* If the Deployment has not reached a Ready state after 5 minutes, it will
* If the Deployment has not reached a Ready state after 10 minutes, it will
* time out and mark the resource update as Failed. You can override the default timeout value
* by setting the 'customTimeouts' option on the resource.
*/
Expand Down
2 changes: 1 addition & 1 deletion sdk/nodejs/apps/v1beta2/StatefulSet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import { getVersion } from "../../version";
* and '.status.readyReplicas'.
* 2. The value of '.status.updateRevision' matches '.status.currentRevision'.
*
* If the StatefulSet has not reached a Ready state after 5 minutes, it will
* If the StatefulSet has not reached a Ready state after 10 minutes, it will
* time out and mark the resource update as Failed. You can override the default timeout value
* by setting the 'customTimeouts' option on the resource.
*/
Expand Down
2 changes: 1 addition & 1 deletion sdk/nodejs/core/v1/Pod.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { getVersion } from "../../version";
* set to "Running".
* Or (for Jobs): The Pod succeeded ('.status.phase' set to "Succeeded").
*
* If the Pod has not reached a Ready state after 5 minutes, it will
* If the Pod has not reached a Ready state after 10 minutes, it will
* time out and mark the resource update as Failed. You can override the default timeout value
* by setting the 'customTimeouts' option on the resource.
*/
Expand Down
2 changes: 1 addition & 1 deletion sdk/nodejs/extensions/v1beta1/Deployment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import { getVersion } from "../../version";
* because it doesn't do a rollout (i.e., it simply creates the Deployment and
* corresponding ReplicaSet), and therefore there is no rollout to mark as 'Progressing'.
*
* If the Deployment has not reached a Ready state after 5 minutes, it will
* If the Deployment has not reached a Ready state after 10 minutes, it will
* time out and mark the resource update as Failed. You can override the default timeout value
* by setting the 'customTimeouts' option on the resource.
*/
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/apps/v1/Deployment.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class Deployment(pulumi.CustomResource):
because it doesn't do a rollout (i.e., it simply creates the Deployment and
corresponding ReplicaSet), and therefore there is no rollout to mark as 'Progressing'.
If the Deployment has not reached a Ready state after 5 minutes, it will
If the Deployment has not reached a Ready state after 10 minutes, it will
time out and mark the resource update as Failed. You can override the default timeout value
by setting the 'customTimeouts' option on the resource.
"""
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/apps/v1/StatefulSet.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class StatefulSet(pulumi.CustomResource):
and '.status.readyReplicas'.
2. The value of '.status.updateRevision' matches '.status.currentRevision'.
If the StatefulSet has not reached a Ready state after 5 minutes, it will
If the StatefulSet has not reached a Ready state after 10 minutes, it will
time out and mark the resource update as Failed. You can override the default timeout value
by setting the 'customTimeouts' option on the resource.
"""
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/apps/v1beta1/Deployment.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class Deployment(pulumi.CustomResource):
because it doesn't do a rollout (i.e., it simply creates the Deployment and
corresponding ReplicaSet), and therefore there is no rollout to mark as 'Progressing'.
If the Deployment has not reached a Ready state after 5 minutes, it will
If the Deployment has not reached a Ready state after 10 minutes, it will
time out and mark the resource update as Failed. You can override the default timeout value
by setting the 'customTimeouts' option on the resource.
"""
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/apps/v1beta1/StatefulSet.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class StatefulSet(pulumi.CustomResource):
and '.status.readyReplicas'.
2. The value of '.status.updateRevision' matches '.status.currentRevision'.
If the StatefulSet has not reached a Ready state after 5 minutes, it will
If the StatefulSet has not reached a Ready state after 10 minutes, it will
time out and mark the resource update as Failed. You can override the default timeout value
by setting the 'customTimeouts' option on the resource.
"""
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/apps/v1beta2/Deployment.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class Deployment(pulumi.CustomResource):
because it doesn't do a rollout (i.e., it simply creates the Deployment and
corresponding ReplicaSet), and therefore there is no rollout to mark as 'Progressing'.
If the Deployment has not reached a Ready state after 5 minutes, it will
If the Deployment has not reached a Ready state after 10 minutes, it will
time out and mark the resource update as Failed. You can override the default timeout value
by setting the 'customTimeouts' option on the resource.
"""
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/apps/v1beta2/StatefulSet.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class StatefulSet(pulumi.CustomResource):
and '.status.readyReplicas'.
2. The value of '.status.updateRevision' matches '.status.currentRevision'.
If the StatefulSet has not reached a Ready state after 5 minutes, it will
If the StatefulSet has not reached a Ready state after 10 minutes, it will
time out and mark the resource update as Failed. You can override the default timeout value
by setting the 'customTimeouts' option on the resource.
"""
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/core/v1/Pod.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Pod(pulumi.CustomResource):
set to "Running".
Or (for Jobs): The Pod succeeded ('.status.phase' set to "Succeeded").
If the Pod has not reached a Ready state after 5 minutes, it will
If the Pod has not reached a Ready state after 10 minutes, it will
time out and mark the resource update as Failed. You can override the default timeout value
by setting the 'customTimeouts' option on the resource.
"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class Deployment(pulumi.CustomResource):
because it doesn't do a rollout (i.e., it simply creates the Deployment and
corresponding ReplicaSet), and therefore there is no rollout to mark as 'Progressing'.
If the Deployment has not reached a Ready state after 5 minutes, it will
If the Deployment has not reached a Ready state after 10 minutes, it will
time out and mark the resource update as Failed. You can override the default timeout value
by setting the 'customTimeouts' option on the resource.
"""
Expand Down

0 comments on commit 3e68249

Please sign in to comment.