Skip to content

Commit

Permalink
Fix an issue with variable casing (#412)
Browse files Browse the repository at this point in the history
We accidentally emitted required variable presence checks against the
property name instead of the property's language name, which resulted in
crashes due to the reference to an unbound variable. In addition, this
commit corrects the presence check to test directly against None instead
of using the bool-ness of the variable.
  • Loading branch information
swgillespie committed Feb 7, 2019
1 parent b3bffb6 commit 5a989d1
Show file tree
Hide file tree
Showing 111 changed files with 121 additions and 121 deletions.
4 changes: 2 additions & 2 deletions pkg/gen/python-templates/kind.py.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ class {{Kind}}(pulumi.CustomResource):
__props__['apiVersion'] = '{{RawAPIVersion}}'
__props__['kind'] = '{{Kind}}'
{{#RequiredProperties}}
if not {{Name}}:
raise TypeError('Missing required property {{Name}}')
if {{LanguageName}} is None:
raise TypeError('Missing required property {{LanguageName}}')
__props__['{{Name}}'] = {{LanguageName}}
{{/RequiredProperties}}
{{#OptionalProperties}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'admissionregistration.k8s.io/v1alpha1'
__props__['kind'] = 'InitializerConfigurationList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'admissionregistration.k8s.io/v1beta1'
__props__['kind'] = 'MutatingWebhookConfigurationList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'admissionregistration.k8s.io/v1beta1'
__props__['kind'] = 'ValidatingWebhookConfigurationList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def __init__(self, __name__, __opts__=None, metadata=None, spec=None, status=Non

__props__['apiVersion'] = 'apiextensions.k8s.io/v1beta1'
__props__['kind'] = 'CustomResourceDefinition'
if not spec:
if spec is None:
raise TypeError('Missing required property spec')
__props__['spec'] = spec
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'apiextensions.k8s.io/v1beta1'
__props__['kind'] = 'CustomResourceDefinitionList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'apiregistration.k8s.io/v1'
__props__['kind'] = 'APIServiceList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'apiregistration.k8s.io/v1beta1'
__props__['kind'] = 'APIServiceList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/apps/v1/ControllerRevision.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def __init__(self, __name__, __opts__=None, data=None, metadata=None, revision=N

__props__['apiVersion'] = 'apps/v1'
__props__['kind'] = 'ControllerRevision'
if not revision:
if revision is None:
raise TypeError('Missing required property revision')
__props__['revision'] = revision
__props__['data'] = data
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'apps/v1'
__props__['kind'] = 'ControllerRevisionList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/apps/v1/DaemonSetList.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'apps/v1'
__props__['kind'] = 'DaemonSetList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/apps/v1/DeploymentList.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'apps/v1'
__props__['kind'] = 'DeploymentList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/apps/v1/ReplicaSetList.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'apps/v1'
__props__['kind'] = 'ReplicaSetList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/apps/v1/StatefulSetList.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'apps/v1'
__props__['kind'] = 'StatefulSetList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def __init__(self, __name__, __opts__=None, data=None, metadata=None, revision=N

__props__['apiVersion'] = 'apps/v1beta1'
__props__['kind'] = 'ControllerRevision'
if not revision:
if revision is None:
raise TypeError('Missing required property revision')
__props__['revision'] = revision
__props__['data'] = data
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'apps/v1beta1'
__props__['kind'] = 'ControllerRevisionList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'apps/v1beta1'
__props__['kind'] = 'DeploymentList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'apps/v1beta1'
__props__['kind'] = 'StatefulSetList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def __init__(self, __name__, __opts__=None, data=None, metadata=None, revision=N

__props__['apiVersion'] = 'apps/v1beta2'
__props__['kind'] = 'ControllerRevision'
if not revision:
if revision is None:
raise TypeError('Missing required property revision')
__props__['revision'] = revision
__props__['data'] = data
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'apps/v1beta2'
__props__['kind'] = 'ControllerRevisionList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/apps/v1beta2/DaemonSetList.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'apps/v1beta2'
__props__['kind'] = 'DaemonSetList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'apps/v1beta2'
__props__['kind'] = 'DeploymentList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'apps/v1beta2'
__props__['kind'] = 'ReplicaSetList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'apps/v1beta2'
__props__['kind'] = 'StatefulSetList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'auditregistration.k8s.io/v1alpha1'
__props__['kind'] = 'AuditSinkList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def __init__(self, __name__, __opts__=None, metadata=None, spec=None, status=Non

__props__['apiVersion'] = 'authentication.k8s.io/v1'
__props__['kind'] = 'TokenReview'
if not spec:
if spec is None:
raise TypeError('Missing required property spec')
__props__['spec'] = spec
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def __init__(self, __name__, __opts__=None, metadata=None, spec=None, status=Non

__props__['apiVersion'] = 'authentication.k8s.io/v1beta1'
__props__['kind'] = 'TokenReview'
if not spec:
if spec is None:
raise TypeError('Missing required property spec')
__props__['spec'] = spec
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def __init__(self, __name__, __opts__=None, metadata=None, spec=None, status=Non

__props__['apiVersion'] = 'authorization.k8s.io/v1'
__props__['kind'] = 'LocalSubjectAccessReview'
if not spec:
if spec is None:
raise TypeError('Missing required property spec')
__props__['spec'] = spec
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def __init__(self, __name__, __opts__=None, metadata=None, spec=None, status=Non

__props__['apiVersion'] = 'authorization.k8s.io/v1'
__props__['kind'] = 'SelfSubjectAccessReview'
if not spec:
if spec is None:
raise TypeError('Missing required property spec')
__props__['spec'] = spec
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def __init__(self, __name__, __opts__=None, metadata=None, spec=None, status=Non

__props__['apiVersion'] = 'authorization.k8s.io/v1'
__props__['kind'] = 'SelfSubjectRulesReview'
if not spec:
if spec is None:
raise TypeError('Missing required property spec')
__props__['spec'] = spec
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, metadata=None, spec=None, status=Non

__props__['apiVersion'] = 'authorization.k8s.io/v1'
__props__['kind'] = 'SubjectAccessReview'
if not spec:
if spec is None:
raise TypeError('Missing required property spec')
__props__['spec'] = spec
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def __init__(self, __name__, __opts__=None, metadata=None, spec=None, status=Non

__props__['apiVersion'] = 'authorization.k8s.io/v1beta1'
__props__['kind'] = 'LocalSubjectAccessReview'
if not spec:
if spec is None:
raise TypeError('Missing required property spec')
__props__['spec'] = spec
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def __init__(self, __name__, __opts__=None, metadata=None, spec=None, status=Non

__props__['apiVersion'] = 'authorization.k8s.io/v1beta1'
__props__['kind'] = 'SelfSubjectAccessReview'
if not spec:
if spec is None:
raise TypeError('Missing required property spec')
__props__['spec'] = spec
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def __init__(self, __name__, __opts__=None, metadata=None, spec=None, status=Non

__props__['apiVersion'] = 'authorization.k8s.io/v1beta1'
__props__['kind'] = 'SelfSubjectRulesReview'
if not spec:
if spec is None:
raise TypeError('Missing required property spec')
__props__['spec'] = spec
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, metadata=None, spec=None, status=Non

__props__['apiVersion'] = 'authorization.k8s.io/v1beta1'
__props__['kind'] = 'SubjectAccessReview'
if not spec:
if spec is None:
raise TypeError('Missing required property spec')
__props__['spec'] = spec
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'autoscaling/v1'
__props__['kind'] = 'HorizontalPodAutoscalerList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'autoscaling/v2beta1'
__props__['kind'] = 'HorizontalPodAutoscalerList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'autoscaling/v2beta2'
__props__['kind'] = 'HorizontalPodAutoscalerList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/batch/v1/JobList.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'batch/v1'
__props__['kind'] = 'JobList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/batch/v1beta1/CronJobList.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'batch/v1beta1'
__props__['kind'] = 'CronJobList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/batch/v2alpha1/CronJobList.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'batch/v2alpha1'
__props__['kind'] = 'CronJobList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'certificates.k8s.io/v1beta1'
__props__['kind'] = 'CertificateSigningRequestList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def __init__(self, __name__, __opts__=None, items=None, metadata=None):

__props__['apiVersion'] = 'coordination.k8s.io/v1beta1'
__props__['kind'] = 'LeaseList'
if not items:
if items is None:
raise TypeError('Missing required property items')
__props__['items'] = items
__props__['metadata'] = metadata
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/pulumi_kubernetes/core/v1/Binding.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def __init__(self, __name__, __opts__=None, metadata=None, target=None):

__props__['apiVersion'] = 'v1'
__props__['kind'] = 'Binding'
if not target:
if target is None:
raise TypeError('Missing required property target')
__props__['target'] = target
__props__['metadata'] = metadata
Expand Down
Loading

0 comments on commit 5a989d1

Please sign in to comment.