Fix an issue with variable casing #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We accidentally emitted required variable presence checks against the property name instead of the property's language name, which resulted in crashes due to the reference to an unbound variable. In addition, this commit corrects the presence check to test directly against None instead of using the bool-ness of the variable.
hausdorff
approved these changes
Feb 7, 2019
lblackstone
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We accidentally emitted required variable presence checks against the
property name instead of the property's language name, which resulted in
crashes due to the reference to an unbound variable. In addition, this
commit corrects the presence check to test directly against None instead
of using the bool-ness of the variable.
FIxes #411.