Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with variable casing #412

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

swgillespie
Copy link
Contributor

We accidentally emitted required variable presence checks against the
property name instead of the property's language name, which resulted in
crashes due to the reference to an unbound variable. In addition, this
commit corrects the presence check to test directly against None instead
of using the bool-ness of the variable.

FIxes #411.

We accidentally emitted required variable presence checks against the
property name instead of the property's language name, which resulted in
crashes due to the reference to an unbound variable. In addition, this
commit corrects the presence check to test directly against None instead
of using the bool-ness of the variable.
Copy link
Contributor

@hausdorff hausdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked through every name, but the changes to the template look correct to me.

@swgillespie swgillespie merged commit 5a989d1 into master Feb 7, 2019
@pulumi-bot pulumi-bot deleted the swgillespie/python-presence-checks branch February 7, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants