Skip to content

Commit

Permalink
Remove duplicated 'shell quoting' for path (#846)
Browse files Browse the repository at this point in the history
  • Loading branch information
lblackstone committed Oct 16, 2019
1 parent 715de59 commit 7f66549
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
- v1.15.x
- v1.14.x

### Improvements

- Fix a bug that causes helm crash when referencing 'scoped packages' that start with '@'. (https://github.com/pulumi/pulumi-kubernetes/pull/846)

## 1.2.1 (October 10, 2019)

### Supported Kubernetes versions
Expand Down
2 changes: 1 addition & 1 deletion pkg/gen/nodejs-templates/helm/v2/helm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ export class Chart extends yaml.CollectionComponentResource {
nodepath.join(chartDir.name, fetchedChartName, "values.yaml")
);
} else {
chart = path.quotePath(cfg.path);
chart = cfg.path;
defaultValues = path.quotePath(nodepath.join(chart, "values.yaml"));
}

Expand Down
2 changes: 1 addition & 1 deletion sdk/nodejs/helm/v2/helm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ export class Chart extends yaml.CollectionComponentResource {
nodepath.join(chartDir.name, fetchedChartName, "values.yaml")
);
} else {
chart = path.quotePath(cfg.path);
chart = cfg.path;
defaultValues = path.quotePath(nodepath.join(chart, "values.yaml"));
}

Expand Down

0 comments on commit 7f66549

Please sign in to comment.