Remove doubled 'shell quoting' for path #846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matheus Miranda <matheusmirandalacerda@gmail.com>
MatheusMiranda
changed the title
Signed-off-by: Matheus Miranda <matheusmirandalacerda@gmail.com>
Merged
|
Thanks for your contribution, @MatheusMiranda! I've opened #848 to test your PR (see https://github.com/pulumi/home/issues/562 for explanation) and added a commit that prevents your change from being overwritten on build. |
lblackstone
added a commit
that referenced
this pull request
Oct 16, 2019
|
Tests passed, so I went ahead and merged the changes in via #848. |
|
@lblackstone Nice! Thank you, very much 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matheus Miranda matheusmirandalacerda@gmail.com
Proposed changes
Removed doubled call on 'quotePath' function, it adds '\\\@' to the path instead of just '\@', helm then fails on finding templates configs for NPM 'scoped packages'. E.g: