Don't replace PVCs when resources change (#1705)

* Don't replace PVCs when resources change

* gofmt

* add changelog entry

* fix replacement on PVCs

* add changelog note

* Update CHANGELOG.md

Co-authored-by: Vivek Lakshmanan <vivek@pulumi.com>

CHANGELOG.md

@@ -1,5 +1,7 @@
 ## HEAD (Unreleased)
-(None)
+
+- Don't replace PVC on .spec.resources.requests or .limits change. (https://github.com/pulumi/pulumi-kubernetes/pull/1705)
+    - *NOTE*: User's will now need to use the `replaceOnChanges` resource option for PVCs if modifying requests or limits to trigger replacement
 
 ## 3.7.0 (September 3, 2021)
 - Add initial support for a Helm release resource - `kubernetes:helm.sh/v3:Release. Currently available in Beta (https://github.com/pulumi/pulumi-kubernetes/pull/1677)

provider/pkg/provider/diff.go

@@ -105,11 +105,7 @@ var core = _versions{
 			}),
 		"PersistentVolumeClaim": append(
 			properties{
-				".spec",
 				".spec.accessModes",
-				".spec.resources",
-				".spec.resources.limits",
-				".spec.resources.requests",
 				".spec.selector",
 				".spec.storageClassName",
 				".spec.volumeName",

provider/pkg/provider/diff_test.go

@@ -158,6 +158,15 @@ func TestPatchToDiff(t *testing.T) {
 			oldInputs: object{"spec": object{"containers": list{object{"name": "nginx", "image": "nginx"}}}},
 			expected:  expected{},
 		},
+		{
+			name:  `PVC resources don't trigger a replace.`,
+			group: "core", version: "v1", kind: "PersistentVolumeClaim",
+			old: object{"spec": object{"resources": object{"requests": object{"storage": "10Gi"}}}},
+			new: object{"spec": object{"resources": object{"requests": object{"storage": "20Gi"}}}},
+			expected: expected{
+				"spec.resources.requests.storage": U,
+			},
+		},
 	}
 
 	for _, tt := range tests {