Don't replace PVCs when resources change

[jaxxstorm]

PVCs often contain critical data that users don't want to lose.

Having the resources field trigger a replace can mean that users can't take advantage of volume resizing.

This allows users to resize volumes and update the field without worrying about a triggering of replacements

Related issues (optional)

fixes #1665

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[roderik]

On AWS, the default storage class does not allow volume expansion. That takes a complex installation of the CSI driver. (which i have so no issue for me personally)

Even so, this would be a breaking change for anyone depending on a replace on request change (which is needed with AWS gp2). The "best" solution would be to check the underlying storageclass to see if it has volume expansion enabled. Otherwise, i think this needs to be an extra options to enable this.

[jaxxstorm]

@roderik - unfortunately there isn't a way to examine the storageclass to determine if the PVC is replaceable.

This mechanism allows users to do a replace by opting in (using the replacement annotation)

My logic here is that destroying PVCs is inherently a bad practice as it will nearly always contain user data that is required.

[roderik]

@roderik - unfortunately there isn't a way to examine the storageclass to determine if the PVC is replaceable.

This mechanism allows users to do a replace by opting in (using the replacement annotation)

My logic here is that destroying PVCs is inherently a bad practice as it will nearly always contain user data that is required.

I follow that logic and it will error out if someone depends on this dangerous behavior and will not destroy anything or any data. That is a big improvement over the current behavior.

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[lblackstone]

I'm ok with this change, but let's add a note to the changelog that users can retain the previous behavior by setting the replaceOnChanges option, possibly with an example.

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.