-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm.v3.Chart doesn't render charts with "helm.sh/hook": pre-install,pre-upgrade
in annotations
#1335
Comments
I've hit this issue attempting to deploy the If I clone the chart and just run a |
@Place1 here's my quick workaround, just in case: https://gist.github.com/zarkone/d1868aa59a9ea2cec3c86982c0e42307. |
We've encountered the same bug. We verified using the yaml render provider that many resources of the ingress-nginx helm chart were never rendered by Pulumi. However, we found a workaround: use the same chart but with helm version 2 instead ( |
Yes, Jobs are missing when using Chart v3 in pulumi, but it is working when using helm command line Yes, using v2 solves for, But previously i thought v2 is for helm v2 (which requires tiller) thats why i avoided it first. |
But helm v2 is deprecated as of #1344 |
Also using v2 crds will not install, does anybody have another alternative? |
I believe this is tracked also in #555. |
Sorry for the delayed response here. I found the issue and have a fix in the linked PR, which should be included in this week's release. |
Thank you so much for your PR @lblackstone , I am indeed myself facing the same issue in nginx helm chart and its admission webhooks. I amvery much expecting the pulumi release which will include your PR |
oh gosh, @lblackstone my issue with NGINX admission webhooks is solved by upgrading to @pulumi/kubernetes |
Problem description
i’ve tried to install ingress-controller using
helm.v3.Chart
and it failed: it turns out it was because admission createSecret job didn’t start, -- resource was not created by Pulumi. I’ve tried to install it with helm CLI and it went fine, — “admission createSecret” job appeared and completedI’ve cloned those charts and played around with it locally — if I remove
"helm.sh/hook": pre-install,pre-upgrade
from metadata/annotations in Job template than Pulumi creates the Job. It looks like those hooks are not supported properly: I got this problem while doing clean install.After short exploration of Pulumi code i've found that
helm template
command is used to render YAML. However, invocation ofhelm template
from CLI gives me valid YAML with jobs, i.e. if I apply it from Pulumi -- it does create those Jobs and other missing resources -- which is actually my workaround for this situation.Errors & Logs
Affected product version(s)
pulumi nodejs
Reproducing the issue
The text was updated successfully, but these errors were encountered: