Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Helm v2 SDKs #1344

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Deprecate Helm v2 SDKs #1344

merged 1 commit into from
Oct 6, 2020

Conversation

lblackstone
Copy link
Member

Proposed changes

Related issues (optional)

Fix #1342

@github-actions
Copy link

github-actions bot commented Oct 6, 2020

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Oct 6, 2020

Please view the PR build [Here][1]
[1]: https://github.com/pulumi/pulumi-kubernetes/actions/runs/292208128

@pulumi pulumi deleted a comment from github-actions bot Oct 6, 2020
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should nuget/Pulumi.Kubernetes.2.1.0-alpha.1601933518.nupkg be deleted?

LGTM otherwise.

provider/pkg/gen/nodejs-templates/helm/v2/helm.ts Outdated Show resolved Hide resolved
provider/pkg/gen/python-templates/helm/v2/helm.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 6, 2020

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Oct 6, 2020

Please view the PR build [Here][1]
[1]: https://github.com/pulumi/pulumi-kubernetes/actions/runs/292245408

@lblackstone lblackstone merged commit b71e4d4 into master Oct 6, 2020
@pulumi-bot pulumi-bot deleted the lblackstone/deprecate-helm-2 branch October 6, 2020 22:18
lblackstone added a commit that referenced this pull request Oct 12, 2020
lblackstone added a commit that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Helm v2 support
2 participants