Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting ResourceOptions inside transformations #574

Closed
lukehoban opened this issue May 29, 2019 · 0 comments · Fixed by #575
Closed

Support setting ResourceOptions inside transformations #574

lukehoban opened this issue May 29, 2019 · 0 comments · Fixed by #575
Assignees
@lukehoban
Milestone
0.23

Comments

@lukehoban
Copy link
Member

ResourceOptions are often important for controlling how resources are deployed with Pulumi. today, charts and yaml files can be deployed with Pulumi, and a custom ResourceOptions can be passed into all resources. However, it is not possible to provide specific ResourceOptions for individual resources or groups of resources. For example, it is not possible to add additionalSecretOutputs to fields which should be marked secret, or protect to resources which should not be allowed to be deleted.

We should augment transformations to allow users to add/change ResourceOptions for individual resources.

See also #546 (comment).
@lukehoban lukehoban self-assigned this May 29, 2019
@lukehoban lukehoban added this to the 0.23 milestone May 29, 2019
@lukehoban lukehoban mentioned this issue May 29, 2019
Closed
lukehoban added a commit that referenced this issue May 29, 2019
@lukehoban
Allow customizing ResourceOptions in transformations
77151ba 
Adds the ability for transformations to see the current ResourceOptions and modify it if desired on an per-resource basis.

Fixes #574.
@lukehoban lukehoban mentioned this issue May 29, 2019
Merged
lukehoban added a commit that referenced this issue May 29, 2019
@lukehoban
Allow customizing ResourceOptions in transformations
5d2db36 
Adds the ability for transformations to see the current ResourceOptions and modify it if desired on an per-resource basis.

Fixes #574.
lukehoban added a commit that referenced this issue May 30, 2019
@lukehoban
Allow customizing ResourceOptions in transformations (#575)
0e3dcef 
* Allow customizing ResourceOptions in transformations

Adds the ability for transformations to see the current ResourceOptions and modify it if desired on an per-resource basis.

Fixes #574.

* Add CHANGELOG

* Add Python support

* Update CHANGELOG
@lukehoban lukehoban mentioned this issue Jun 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukehoban lukehoban

Labels
None yet
Projects
None yet
Milestone
0.23
Development

Successfully merging a pull request may close this issue.

Allow customizing ResourceOptions in transformations pulumi/pulumi-kubernetes
1 participant
@lukehoban