Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment claims to be initialized immediately when rollout fails #652

Closed
hausdorff opened this issue Jul 25, 2019 · 2 comments
Closed
Assignees
Labels
p1 A bug severe enough to be the next item assigned to an engineer
Milestone

Comments

@hausdorff
Copy link
Contributor

Take a vanilla v1 deployment, change the image tag to be something that doesn't exist, and a pulumi up will report success immediately.

@hausdorff hausdorff added this to the 0.25 milestone Jul 25, 2019
@lukehoban
Copy link
Member

Isn't this the same as #611?

The text of the descriptions is effectively identical:

I update an existing Deployment to reference an erroneous image name, the update succeeds, even though the resulting Pod ends up in an endless backoff.

Take a vanilla v1 deployment, change the image tag to be something that doesn't exist, and a pulumi up will report success immediately.

@hausdorff
Copy link
Contributor Author

I just came back to say: I thought we checked in #646 today so I thought this was a regression. With that PR this does seem to be fixed.

@infin8x infin8x added the p1 A bug severe enough to be the next item assigned to an engineer label Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 A bug severe enough to be the next item assigned to an engineer
Projects
None yet
Development

No branches or pull requests

4 participants