Fix Deployment await logic #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
force-pushed
the
lblackstone/deployment-await-fix
branch
from
d39e6fc
to
7c6da3c
Compare
hausdorff
reviewed
Jul 23, 2019
|
Also we concluded that this partial revert breaks old versions of |
Right, as shown by the failing test. Instead of reverting, I'm working on fixing the workaround logic for the |
lblackstone
force-pushed
the
lblackstone/deployment-await-fix
branch
from
7c6da3c
to
48a6953
Compare
lblackstone
force-pushed
the
lblackstone/deployment-await-fix
branch
3 times, most recently
from
69c3083
to
0c59e2d
Compare
hausdorff
reviewed
Jul 24, 2019
The Deployment await logic was incorrectly checking for the `extensions/v1beta1` apiVersion, which was causing the await logic to erroneously pass for change triggered rollouts, even if the Deployment was invalid. The fix required two changes: 1) For some reason, the resource client was defaulting to the `extensions/v1beta1` apiVersion, even though recent versions were available on the cluster. Updated the client to prefer newer apiVersions. 2) Updated await logic for the old apiVersion to use the input object rather than a received watch Event. Regardless of the apiVersion of the received watch Event, the relevant status field will be missing if the Deployment was created with the `extensions/v1beta1` API.
lblackstone
force-pushed
the
lblackstone/deployment-await-fix
branch
from
0c59e2d
to
35a0467
Compare
hausdorff
approved these changes
Jul 25, 2019
|
Also note that this is not a fix for #611 any more. It is a fix for a related issue. |
|
@hausdorff Opened #656 to track the portion I'm not addressing here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Deployment await logic had a bug for the old
extensions/v1beta1apiVersion which was causing the await logic to erroneously pass for
change triggered rollouts, even if the Deployment was invalid.
For some reason, the resource client was defaulting to
the old apiVersion, even though recent versions were available on the
cluster. Updated the client to ignore
extensions/v1beta1, andreverted the buggy await logic related to that apiVersion.
Fixes #611