Generate NodeJS SDK from schema #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Makefile # provider/cmd/pulumi-gen-kubernetes/main.go # sdk/nodejs/extensions/v1beta1/Ingress.ts # sdk/nodejs/storage/v1beta1/CSINode.ts # sdk/nodejs/types/input.ts # sdk/nodejs/types/output.ts
typeString broken in yaml.ts
# Conflicts: # provider/cmd/pulumi-gen-kubernetes/main.go # provider/go.sum # tests/go.sum
lblackstone
commented
Jun 8, 2020
Comment on lines
+169
to
+170
| files["path.ts"] = mustLoadFile(filepath.Join(templateDir, "path.ts")) | ||
| files["tests/path.ts"] = mustLoadFile(filepath.Join(templateDir, "tests", "path.ts")) |
There was a problem hiding this comment.
@pgavlin These two files are not part of the user-facing SDK (i.e. I don't want them in the top level index.ts. This has the side-effect of not including them in the package.json list of files. Is this ok, or do you have another suggestion?
There was a problem hiding this comment.
I think that's okay. I think our JS doc generator relies upon public surface area being in package.json, but sounds like this is not public surface area. I don't know of anything else that relies on the files list in package.json
pgavlin
approved these changes
Jun 9, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Switch NodeJS code generation over to upstream codegen packages based on the schema.
Related issues (optional)
Fixes #1053