-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate NodeJS SDK from schema #1151
Merged
Merged
Changes from 40 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
bd5612a
WIP
lblackstone 7f384d4
WIP - schema-based codegen
lblackstone bc0a0d3
Add pulumiComment to resource descriptions
lblackstone 6555eca
Fix module names
lblackstone 5b25b9a
More module name fixes
lblackstone ba4c492
Fix getters
lblackstone b39256e
Fix constructors
lblackstone 6f22d57
Add const values
lblackstone 8f4b574
Fix package.json and update to k8s 1.18
lblackstone f29a318
SDK compiles
lblackstone be2ee14
Generate yaml.ts
lblackstone 4d91cec
Simplify yaml.ts codegen
lblackstone 68949e7
WIP
lblackstone b8cc3c0
YAML working
lblackstone ee49549
Merge branch 'master' into lblackstone/ts-schema-gen
lblackstone ca7cc2c
Merge branch 'master' into lblackstone/ts-schema-gen
lblackstone 796c43e
More cleanup
lblackstone de52a1a
WIP - backward compat
lblackstone a7ff111
Merge branch 'master' into lblackstone/ts-schema-gen
lblackstone c579335
Fix YAML
lblackstone 123198d
Add CustomResource overlay
lblackstone 2fe081c
Pass overlays into codegen
lblackstone e2dcf2c
Set compat mode
lblackstone 63c123f
Cleanup
lblackstone d74fb0e
Pull in codegen changes
lblackstone 31e0efd
Update readme generation
lblackstone c013cda
Merge branch 'master' into lblackstone/ts-schema-gen
lblackstone 0638355
make ensure
lblackstone 6ec87d6
readme
lblackstone b636d6a
Refactoring and docs
lblackstone a200713
Doc warning
lblackstone 310b2f8
More docs
lblackstone 20918d2
Pull in latest p/p changes
lblackstone 80b7ade
More fixes
lblackstone 5d55eac
Revert makefile changes
lblackstone 812b8e6
changelog
lblackstone a3e0012
Use common getVersion
lblackstone 3ae203f
Fix go.mod
lblackstone ed37d8d
Fix package exports
lblackstone 38c3550
Fix output types
lblackstone fe6f47e
YAML cleanup
lblackstone f68e5e6
Merge branch 'master' into lblackstone/ts-schema-gen
lblackstone 2e2d197
Regenerate SDK with schema fix
lblackstone 6c6ab4f
Fix YAML
lblackstone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pgavlin These two files are not part of the user-facing SDK (i.e. I don't want them in the top level
index.ts
. This has the side-effect of not including them in thepackage.json
list of files. Is this ok, or do you have another suggestion?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @lukehoban
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's okay. I think our JS doc generator relies upon public surface area being in package.json, but sounds like this is not public surface area. I don't know of anything else that relies on the files list in package.json