Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update helm.ts: add try-catch over helm version #1170

Closed
wants to merge 3 commits into from

Conversation

0x53A
Copy link
Contributor

@0x53A 0x53A commented Jun 18, 2020

fixes #1169

I did this change locally in the compiled JS, which fixed my issue.

(I edited it in the github UI bc I was too lazy to clone, let's see if CI likes it)


Feel free to close it if this isn't the correct approach, I'm not too familiar with node

@jaxxstorm jaxxstorm self-requested a review June 18, 2020 21:32
@jaxxstorm
Copy link
Contributor

thanks so much for contributing this! I'll get it tested and early next week

@leezen
Copy link
Contributor

leezen commented Jun 18, 2020

FYI I believe this code is generated from a template /provider/pkg/gen/nodejs-templates/helm/v2/helm.ts so you'll want to update the template instead of the generated file

@jaxxstorm
Copy link
Contributor

Hi @0x53A - i've opened another PR for this here:

#1176

To make sure the tests pass, and fix the merge conflicts. I'll close this out - your contributions will still be included. Thanks so much for this!

@jaxxstorm jaxxstorm closed this Jun 24, 2020
@0x53A
Copy link
Contributor Author

0x53A commented Jun 24, 2020

thanks for taking care of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm version fails
3 participants