Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle networking/v1beta1 Ingress resources #1221

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

lblackstone
Copy link
Member

Proposed changes

Update the await logic to handle the latest Ingress
apiVersion.

Related issues (optional)

Fix #875

Update the await logic to handle the latest Ingress
apiVersion.
@lblackstone lblackstone requested a review from metral July 23, 2020 22:11
Copy link
Contributor

@metral metral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Was this just a simple move of the package?
(guessing nothing changes for the resource itself as far as we're concerned)

@lblackstone
Copy link
Member Author

Was this just a simple move of the package?
(guessing nothing changes for the resource itself as far as we're concerned)

Yeah, I just switched to using the latest version of the struct to deserialize the Ingress resources. This should be backward compatible (same approach is used for other resources), and the tests still pass, so hopefully this should do the trick.

@cangussu
Copy link

I'm not sure this is backward compatible, as I got an error trying to use old Ingress schema when following this guide. I made some changes (pulumi/kubernetes-guides#38) after a tip from @jaxxstorm and it worked fine.

Besides that, think this comment should also be updated:
https://github.com/pulumi/pulumi-kubernetes/blob/master/provider/pkg/await/ingress.go#L31

@lblackstone
Copy link
Member Author

@cangussu Thanks for letting us know. I opened a new issue to investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Await logic doesn't handle networking/v1beta1:Ingress correctly
3 participants