Update json-patch mod to fix hangs on pulumi update

[lblackstone]

Proposed changes

A performance bug was discovered that can cause CRD
diffs to fail. This bug is fixed in an open PR [1] to the upstream
repo, but has not been merged yet. In the meantime, I forked
the json-patch repo, and applied the fix [2]. This change will be
reverted once the upstream patch merges, and the module will
be updated to point at the fixed changeset.

[1] evanphx/json-patch#108
[2] https://github.com/pulumi/json-patch

Related issues (optional)

Fix #1222

[ninja-]

So as I understand, it would still fail during apply because helm cli is being invoked?

[ninja-]

The code that calls the CLI looks pretty simple to port, I know it was somewhere on the roadmap but what were the challenges there? I could spend some time working to get helm cli out of the way and use the go lib.
As I understand more or less, helm cli is just used to fetch and render templates into yaml and then manifests are passed into normal kubernetes engine of pulumi?

[lblackstone]

The code that calls the CLI looks pretty simple to port, I know it was somewhere on the roadmap but what were the challenges there? I could spend some time working to get helm cli out of the way and use the go lib.

I’d be glad to move Helm support to use the library, but I don’t think it’s directly related to this issue since the diffs are handled by the provider.

I’d expect it to be fairly straightforward to port. The main issue would be supporting all of the existing config flags. Kustomise support is implemented using the library, so that’s a good example of what the work would look like.

As I understand more or less, helm cli is just used to fetch and render templates into yaml and then manifests are passed into normal kubernetes engine of pulumi?

Right; we only use the CLI to fetch the Chart and template YAML

[metral]

Is this a temp move until upstream is patched? Or are we considering forking long-term?

[lblackstone]

Is this a temp move until upstream is patched? Or are we considering forking long-term?

This change will be reverted once the upstream patch merges, and the module will be updated to point at the fixed changeset.