Fix map comparison of nil values and missing keys #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2020
|
/assign @evanphx |
liggitt
added a commit
to liggitt/kubernetes
that referenced
this pull request
Jun 24, 2020
|
fyi - green CI in kubernetes with this fix at kubernetes/kubernetes#92482 |
|
@evanphx would you mind looking over this when you have a chance? |
|
@evanphx friendly ping |
lblackstone
added a commit
to pulumi/pulumi-kubernetes
that referenced
this pull request
Jul 31, 2020
A performance bug was discovered that can cause CRD diffs to fail. This bug is fixed in an open PR [1] to the upstream repo, but has not been merged yet. In the meantime, I forked the json-patch repo, and applied the fix [2]. This change will be reverted once the upstream patch merges, and the module will be updated to point at the fixed changeset. [1] evanphx/json-patch#108 [2] https://github.com/pulumi/json-patch
lblackstone
added a commit
to pulumi/pulumi-kubernetes
that referenced
this pull request
Aug 1, 2020
* Update json-patch mod to fix hangs on pulumi update A performance bug was discovered that can cause CRD diffs to fail. This bug is fixed in an open PR [1] to the upstream repo, but has not been merged yet. In the meantime, I forked the json-patch repo, and applied the fix [2]. This change will be reverted once the upstream patch merges, and the module will be updated to point at the fixed changeset. [1] evanphx/json-patch#108 [2] https://github.com/pulumi/json-patch * gofmt
|
if this and #111 were merged, and a v4.8.0 release cut, 4.x consumers could pick up performance and panic bugfixes on the 4.x stream without getting breaking behavior changes, which would be great |
|
thank you very much, this gives us a level we can use on release branches |
I did open #113 to make 4.x releases addressable by tag again, which is the last issue I'm aware of with the 4.x stream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing matchesValue map comparison treats missing keys and nil values equivalently, which means it can return true for maps that are not actually equal
cc @logicalhan