Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map comparison of nil values and missing keys #108

Merged
merged 1 commit into from
Aug 8, 2020

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Jun 24, 2020

The existing matchesValue map comparison treats missing keys and nil values equivalently, which means it can return true for maps that are not actually equal

cc @logicalhan

Copy link
Contributor

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@logicalhan
Copy link
Contributor

/assign @evanphx

liggitt added a commit to liggitt/kubernetes that referenced this pull request Jun 24, 2020
@liggitt
Copy link
Contributor Author

liggitt commented Jun 25, 2020

fyi - green CI in kubernetes with this fix at kubernetes/kubernetes#92482

@logicalhan
Copy link
Contributor

@evanphx would you mind looking over this when you have a chance?

@liggitt
Copy link
Contributor Author

liggitt commented Jul 25, 2020

@evanphx friendly ping

lblackstone added a commit to pulumi/pulumi-kubernetes that referenced this pull request Jul 31, 2020
A performance bug was discovered that can cause CRD
diffs to fail. This bug is fixed in an open PR [1] to the upstream
repo, but has not been merged yet. In the meantime, I forked
the json-patch repo, and applied the fix [2]. This change will be
reverted once the upstream patch merges, and the module will
be updated to point at the fixed changeset.

[1] evanphx/json-patch#108
[2] https://github.com/pulumi/json-patch
lblackstone added a commit to pulumi/pulumi-kubernetes that referenced this pull request Aug 1, 2020
* Update json-patch mod to fix hangs on pulumi update

A performance bug was discovered that can cause CRD
diffs to fail. This bug is fixed in an open PR [1] to the upstream
repo, but has not been merged yet. In the meantime, I forked
the json-patch repo, and applied the fix [2]. This change will be
reverted once the upstream patch merges, and the module will
be updated to point at the fixed changeset.

[1] evanphx/json-patch#108
[2] https://github.com/pulumi/json-patch

* gofmt
@liggitt
Copy link
Contributor Author

liggitt commented Aug 5, 2020

if this and #111 were merged, and a v4.8.0 release cut, 4.x consumers could pick up performance and panic bugfixes on the 4.x stream without getting breaking behavior changes, which would be great

@evanphx evanphx merged commit 162e562 into evanphx:master Aug 8, 2020
@evanphx
Copy link
Owner

evanphx commented Aug 8, 2020

So sorry about the delay! @liggitt this at #111 are merged and there is a v4.8.0 tagged against master.

Please let me know if there are still issues and we'll get them sorted quickly.

Again, apologies about the delay.

@liggitt
Copy link
Contributor Author

liggitt commented Aug 8, 2020

thank you very much, this gives us a level we can use on release branches

@liggitt liggitt deleted the map-compare branch August 8, 2020 14:12
@liggitt
Copy link
Contributor Author

liggitt commented Aug 8, 2020

Please let me know if there are still issues and we'll get them sorted quickly.

I did open #113 to make 4.x releases addressable by tag again, which is the last issue I'm aware of with the 4.x stream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants