Switch Helm v3 support to use the native libs #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
force-pushed
the
lblackstone/helm-lib
branch
2 times, most recently
from
894da9e
to
17f62d1
Compare
metral
reviewed
Aug 25, 2020
jaxxstorm
reviewed
Aug 26, 2020
metral
approved these changes
Aug 26, 2020
justinvp
reviewed
Aug 26, 2020
Yes, that's right. I updated the Python tests to create the Chart with v2 and then update to v3, and confirmed no changes. |
Rather than shelling out to the Helm v3 CLI, use the upstream Go packages to implement Helm v3 support in the provider.
lblackstone
force-pushed
the
lblackstone/helm-lib
branch
from
4f2ad27
to
db9ab35
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Rather than shelling out to the Helm v3 CLI, use
the upstream Go packages to implement Helm v3
support in the provider.
TODO:
Update SDKs to invoke the provider's Helm code rather than shelling out to the CLINote: I decided to split the other SDK changes into separate PRs to make it easier to review. This PR includes the core library updates and the Python SDK to make sure it works properly. The v3 URN has been updated to be
kubernetes:helm.sh/v3. Aliases are used to avoid replacements for existing resources. The v2 API will be deprecated in a later update.Related issues (optional)
Part of #920